a475f4a3c1
Ensure that embargoed permissions are correctly displayed by querying for the embedder and requester origin of blocked permissions. The main change is page_info.cc and chrome_page_info_delegate.cc. Everything else is adding a second parameter to a PermissionManager function that is implemented a dozen times. Bug: 1433644 Change-Id: Ib75b4cc0785764bee9f1c68998233cc62e65e2f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4746465 Reviewed-by: Eric Seckler <eseckler@chromium.org> Reviewed-by: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by: Elias Klim <elklm@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Cr-Commit-Position: refs/heads/main@{#1180362}
fuchsia.web - Fuchsia WebEngine and Runners
This directory contains code related to the
fuchsia.web FIDL API.
Specifically, it contains the implementation of Fuchsia WebEngine and code
related to it, including the Runners that use it. Code in this
directory must not be used outside it and its subdirectories.
General information about Chromium on Fuchsia is here.
[TOC]
Code organization
Each of the following subdirectories contain code for a specific Fuchsia service:
./commoncontains code shared by both WebEngine and Runners../runnerscontains implementations of Fuchsiasys.runner../runners/castEnables the Fuchsia system to launch Cast applications.
./shellcontains WebEngineShell, a simple wrapper for launching URLs in WebEngine from the command line../webenginecontains the WebEngine implementation. WebEngine is an implementation offuchsia.webthat enables Fuchsia Components to render web content using Chrome's Content layer../webinstance_hostcontains code for WebEngine clients to directly instantiate a WebInstance Component (web_instance.cm) using the WebEngine package.
Test code
There are 3 major types of tests within this directory:
- Unit tests: Exercise a single class in isolation, allowing full control over the external environment of this class.
- Browser tests: Spawn a full browser process and its child processes. The test code is run inside the browser process, allowing for full access to the browser code - but not other processes.
- Integration tests: Exercise the published FIDL API of a Fuchsia Component. For
instance,
//fuchsia_web/webengine:web_engine_integration_testsmake use of the//fuchsia_web/webengine:web_enginecomponent. The test code runs in a separate process in a separate Fuchsia Component, allowing only access to the published API of the component under test.
Integration tests are more resource-intensive than browser tests, which are in turn more expensive than unit tests. Therefore, when writing new tests, it is preferred to write unit tests over browser tests over integration tests.
As a general rule, test-only code should live in the same directory as the code
under test with an explicit file name, either fake_*, test_*,
*_unittest.cc, *_ browsertest.cc or *_integration_test.cc.
Test code that is shared across Components should live in a dedicated ``test
directory. For example, the //fuchsia_web/webengine/test directory, which
contains code shared by all browser tests, and
//fuchsia_web/common/test, which contains code shared by tests for both
WebEngine and Runners.