a5676c607e
The compilation on ChromeOS failed for the original CL (http://crrev.com/2811673002), it is likely that a simple rebase fixes the issue. This patchset is equivalent to issue 2740143002 at patchset 14, simply another rebase took place. Original description follows: This CL is a first step to inlining base::ListValue. It is proposed to use an std::vector<base::Value> as the underlying ListStorage. This CL implements the change and updates the code accordingly. BUG=646113 TBR=brettw@chromium.org,rdevlin.cronin@chromium.org,flackr@chromium.org,skym@chromium.org,rsesek@chromium.org,bajones@chromium.org,dbeam@chromium.org,stevenjb@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2809023003 Cr-Commit-Position: refs/heads/master@{#463684}
41 lines
1.3 KiB
C++
41 lines
1.3 KiB
C++
// Copyright 2016 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "components/ntp_snippets/pref_util.h"
|
|
|
|
#include <memory>
|
|
|
|
#include "base/values.h"
|
|
#include "components/prefs/pref_service.h"
|
|
|
|
namespace ntp_snippets {
|
|
namespace prefs {
|
|
|
|
std::set<std::string> ReadDismissedIDsFromPrefs(const PrefService& pref_service,
|
|
const std::string& pref_name) {
|
|
std::set<std::string> dismissed_ids;
|
|
const base::ListValue* list = pref_service.GetList(pref_name);
|
|
for (const base::Value& value : *list) {
|
|
std::string dismissed_id;
|
|
bool success = value.GetAsString(&dismissed_id);
|
|
DCHECK(success) << "Failed to parse dismissed id from prefs param "
|
|
<< pref_name << " into string.";
|
|
dismissed_ids.insert(dismissed_id);
|
|
}
|
|
return dismissed_ids;
|
|
}
|
|
|
|
void StoreDismissedIDsToPrefs(PrefService* pref_service,
|
|
const std::string& pref_name,
|
|
const std::set<std::string>& dismissed_ids) {
|
|
base::ListValue list;
|
|
for (const std::string& dismissed_id : dismissed_ids) {
|
|
list.AppendString(dismissed_id);
|
|
}
|
|
pref_service->Set(pref_name, list);
|
|
}
|
|
|
|
} // namespace prefs
|
|
} // namespace ntp_snippets
|