
This reverts commit 4b05c17584
.
Reason for revert: Causing compile failure in chrome/browser/ash/chromebox_for_meetings/xu_camera/xu_camera_service.cc
Original change's description:
> Re-enable clang VLA warning
>
> We've finally removed all uses of variable-length arrays from the Chromium codebase (see https://crbug.com/349656479), so we can re-enable clang's warning to ensure no further ones get added.
>
> Fixed: 349656479, 40286317
> Change-Id: I8d62b11c8e7c61ad6c955a9fe221b086706d127c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5707850
> Reviewed-by: Hans Wennborg <hans@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Devon Loehr <dloehr@google.com>
> Cr-Commit-Position: refs/heads/main@{#1354667}
Change-Id: I31868abb3a666101a56b37988518b7107c0f2339
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5854358
Reviewed-by: Chan Li <chanli@chromium.org>
Auto-Submit: Devon Loehr <dloehr@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Chan Li <chanli@chromium.org>
Owners-Override: Chan Li <chanli@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354709}
About
//build
contains:
- Core GN templates and configuration
- Core Python build scripts
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium,
v8, etc), it should be kept as self-contained as possible by not referring
to files outside of it. Some exceptions exist (//testing
, select
//third_party
subdirectories), but new dependencies tend to break these other
projects, and so should be avoided.
Changes to //build
should be landed in the Chromium repo. They will then be
replicated to the stand-alone build repo
by the gsubtreed tool.
Note: You can find all directories already available through gsubtreed in the
list of all chromium repos.
Contents
//build/config
- Common templates via.gni
files.//build/toolchain
- GN toolchain definitions.Other .py files
- Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.
Files referenced by //.gn
:
//build/BUILDCONFIG.gn
- Included by allBUILD.gn
files.//build/secondary
- An overlay forBUILD.gn
files. Enables addingBUILD.gn
to directories that live in sub-repositories.//build_overrides
- Refer to //build_overrides/README.md.