647b65eb67
This reverts commit19b5dd0c20. Reason for reland: I re-invert the DPD condition in patchset 2 Original change's description: > Revert "PA: Invert MiraclePtr Platform Enablement Logic" > > This reverts commitc3e9990871. > > Reason for revert: I just realize I inverted the DPD condition > causing it to be enabled in non dcheck builds. > > Original change's description: > > PA: Invert MiraclePtr Platform Enablement Logic > > > > This patch inverts the build flags logic from an "allowlist" of platform > > toward a "deny list". > > > > - **Increased Confidence**: Guarantees MiraclePtr is active everywhere > > unless explicitly disabled, reducing the risk of unexpected > > vulnerabilities on niche platforms. > > > > - **Future-Proofing**: Potentially new platforms automatically inherit > > MiraclePtr from the beginning, eliminating the need to "ship" it one > > more time. > > > > - **Simplified Maintenance**: Focus shifts to maintaining a small, > > explicit list of exceptions rather than a growing list of enabled > > platforms. > > > > What is the "complementary"? > > ----------------------------- > > > > We know from `//build/config/BUILDCONFIG` the current_os is limited to: > > aix , android , chromeos > > fuchsia , ios , linux > > mac , nacl , win > > winuwp , zos > > > > "aix" and "zos" aren't supported by Chrome, only V8. So they can be > > ignored. > > > > Bug: 364466913 > > Change-Id: Ia03f8f18a4b3bb05e4c9d304980cadcf235be3c5 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5837217 > > Reviewed-by: Keishi Hattori <keishi@chromium.org> > > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > > Reviewed-by: Wez <wez@chromium.org> > > Reviewed-by: danakj <danakj@chromium.org> > > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1352670} > > Bug: 364466913 > Change-Id: I7ed0231bfa46b2091041df6ef7c09a7726cfacc1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5844793 > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Owners-Override: Arthur Sonzogni <arthursonzogni@chromium.org> > Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> > Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1352693} Bug: 364466913 Change-Id: I315ccb248b5d6323849883aad085c93db218d2d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5844931 Reviewed-by: danakj <danakj@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Keishi Hattori <keishi@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/main@{#1354441}
Build overrides in GN
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a "standalone" configuration),
and it could be built as part of Chromium. V8 might define a top-level
target, //v8:d8 (a simple executable), that should only be built in the
standalone configuration. To figure out whether or not it should be
in a standalone configuration, v8 can create a file, build_overrides/v8.gni,
that contains a variable, build_standalone_d8 = true.
and import it (as import("//build_overrides/v8.gni") from its top-level
BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would
create its own build_overrides/v8.gni file, and in it set
build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/41240413): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.