aa9e70ed08
This change combines a few mild metrics changes together to save on
metrics review churn. The significant changes are:
* kErrorAbort returned when the browser context is shutting down is
no longer considered an failure/error for (un)registration This is
an expected situation.
* WorkerRegistrationState now only emits *after* registration retries
have been attempted to avoid multi-counting temporary timeout fails
* kErrorScriptEvaluateFailed for worker registration is no longer
considered a failure since it's a syntax error in the developer's
script
* !extension during worker registration and the registration not
succeeding is no longer considered a failure (can happen when
extension is disabled while registration request is in-flight).
!extension and successful is considered a failure though since that
could have implications for future worker registrations for the
extension
* !IsCurrentActivation() after worker registration is considered not
successful since this is an unexpected state
Also makes a no-op change to WorkerRegistrationRetryAttemptsResult to
collapse a redundant if condition.
OBSOLETE_HISTOGRAMS=Reverted incremented histograms to original version since the intent and general logic of the metric is mostly the same as it was. We'll monitor by product version to see differences if needed.
Bug: 346732739
Change-Id: I310f12a648f7dd4d74e61d7d6ad0f6587698df98
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5855267
Auto-Submit: Justin Lulejian <jlulejian@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Justin Lulejian <jlulejian@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1354769}
This will become a reusable extensions module. It implements the core parts of Chrome's extension system, and can be used with any host of the content module.
Some extensions code that is not Chrome-specific still lives in //chrome/browser/extensions and will be moved here.
Technical Documentation: