7dc7416065
In crrev.com/c/5340479, [AXPlatformNodeCocoa accessibilityParent] was implemented to prevent a hang launching PWA apps with VoiceOver on. That implementation calls [self AXParent] which exists in AXPlatformNodeCocoa but not in BrowserAccessibilityCocoa. In BrowserAccessibilityCocoa, the same functionality is provided by [BrowserAccessibilityCocoa parent]. There is a mapping between it and NSAccessibilityParentAttribute. However, AppKit seems to prefer the new API (accessibilityParent) and only falls back on the old API when the new API is not implemented. Thus it appears that [BrowserAccessibilityCocoa parent] has not been called since early March 2024 and could potentially be deleted. Given that the code in BrowserAccessibilityCocoa is slightly different from that of AXPlatformNodeCocoa, it is possible that there are cases the former is still needed which are not covered by existing tests. Therefore, rename parent to accessibilityParent so that the new API can provide access to this subclass's implementation. Include-Ci-Only-Tests: true Cq-Include-Trybots: luci.chromium.try:mac-fieldtrial-tester Bugs: 328011217, 363275809 Change-Id: I7f1f492344e689b492efa0fb6835b8a9ed992c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6039752 Reviewed-by: Jayson Adams <shrike@chromium.org> Commit-Queue: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1391495}
This directory contains UI frameworks used to build various user interface features. This directory is not intended to contain UI features (such as a keyboard).