d383d0b3e4
base::ClampToRange will return bogus results if `lo` is greater than `hi`. This is a source of bugs. Because of this, base::clamp CHECKs in that case. This CL moves users of base::ClampToRange over if they pass their tests with base::clamp, preventing errors in the future. Bug: 1231569 Change-Id: Id12046d6cab2736f9f3c7df068345394f45fd01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3045786 Commit-Queue: Avi Drissman <avi@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Owners-Override: Daniel Cheng <dcheng@chromium.org> Owners-Override: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#905034}
Cast base
cast_features
This file contains tools for checking the feature state of all of the features which affect Cast products. Cast features build upon the Chrome feature system. Some aspects of Cast require the feature system to work differently, however, so some additional logic has been layered on top. Details are available in comments of the header file. The basics are:
- If you are adding a new feature, add it to
cast_features.ccso it lives alongside existing features - Add your new feature to the list of
kFeaturesincast_features.cc
const base::Feature kMyFeature{"my_feature", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature* kFeatures[] = {
// ..other features
&kMyFeature
}