
This CL implements process isolation of documents that set Document-Isolation-Policy. It introduces an AgentClusterKey passed to SiteInfo, which is used to isolate pages with DIP from pages without DIP. In this CL, the AgentClusterKey is only computed for pages with DIP. Pages without DIP only get an AgentClusterKey with an empty URL. Follow-up work will properly compute the AgentClusterKey for all navigations. Bug: 333047378 Change-Id: I86f1fa637f68dfe0932be7b2373323472c19ac7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5588626 Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/main@{#1323878}
142 lines
5.1 KiB
C++
142 lines
5.1 KiB
C++
// Copyright 2024 The Chromium Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "content/browser/agent_cluster_key.h"
|
|
|
|
#include <sstream>
|
|
|
|
#include "base/test/gtest_util.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
#include "url/gurl.h"
|
|
#include "url/origin.h"
|
|
|
|
namespace content {
|
|
|
|
using AgentClusterKeyTest = testing::Test;
|
|
|
|
TEST_F(AgentClusterKeyTest, SiteKeyed) {
|
|
GURL url = GURL("https://a.com");
|
|
AgentClusterKey key = AgentClusterKey::CreateSiteKeyed(url);
|
|
EXPECT_TRUE(key.IsSiteKeyed());
|
|
EXPECT_FALSE(key.IsOriginKeyed());
|
|
EXPECT_EQ(url, key.GetSite());
|
|
EXPECT_EQ(std::nullopt, key.GetCrossOriginIsolationKey());
|
|
ASSERT_DCHECK_DEATH(key.GetOrigin());
|
|
}
|
|
|
|
TEST_F(AgentClusterKeyTest, OriginKeyed) {
|
|
url::Origin origin =
|
|
url::Origin::CreateFromNormalizedTuple("https", "example.com", 443);
|
|
AgentClusterKey key = AgentClusterKey::CreateOriginKeyed(origin);
|
|
EXPECT_FALSE(key.IsSiteKeyed());
|
|
EXPECT_TRUE(key.IsOriginKeyed());
|
|
EXPECT_EQ(origin, key.GetOrigin());
|
|
EXPECT_EQ(std::nullopt, key.GetCrossOriginIsolationKey());
|
|
ASSERT_DCHECK_DEATH(key.GetSite());
|
|
}
|
|
|
|
TEST_F(AgentClusterKeyTest, WithCrossOriginIsolationKey) {
|
|
url::Origin origin =
|
|
url::Origin::CreateFromNormalizedTuple("https", "example.com", 443);
|
|
url::Origin common_coi_origin = url::Origin::CreateFromNormalizedTuple(
|
|
"https", "isolation.example.com", 443);
|
|
AgentClusterKey::CrossOriginIsolationKey isolation_key(
|
|
common_coi_origin, CrossOriginIsolationMode::kConcrete);
|
|
AgentClusterKey key =
|
|
AgentClusterKey::CreateWithCrossOriginIsolationKey(origin, isolation_key);
|
|
|
|
EXPECT_FALSE(key.IsSiteKeyed());
|
|
EXPECT_TRUE(key.IsOriginKeyed());
|
|
EXPECT_EQ(origin, key.GetOrigin());
|
|
EXPECT_EQ(isolation_key, key.GetCrossOriginIsolationKey());
|
|
ASSERT_DCHECK_DEATH(key.GetSite());
|
|
}
|
|
|
|
TEST_F(AgentClusterKeyTest, Comparisons) {
|
|
// Site-keyed
|
|
GURL site_a = GURL("https://a.com");
|
|
GURL site_b = GURL("https://b.com");
|
|
|
|
AgentClusterKey key_site_a = AgentClusterKey::CreateSiteKeyed(site_a);
|
|
AgentClusterKey key_site_b = AgentClusterKey::CreateSiteKeyed(site_b);
|
|
|
|
EXPECT_EQ(key_site_a, key_site_a);
|
|
EXPECT_NE(key_site_a, key_site_b);
|
|
|
|
// Origin-keyed
|
|
url::Origin origin_a = url::Origin::Create(site_a);
|
|
url::Origin origin_b = url::Origin::Create(site_b);
|
|
|
|
AgentClusterKey key_origin_a = AgentClusterKey::CreateOriginKeyed(origin_a);
|
|
AgentClusterKey key_origin_b = AgentClusterKey::CreateOriginKeyed(origin_b);
|
|
|
|
EXPECT_EQ(key_origin_a, key_origin_a);
|
|
EXPECT_NE(key_origin_a, key_origin_b);
|
|
EXPECT_NE(key_origin_a, key_site_a);
|
|
|
|
// With isolation key
|
|
AgentClusterKey::CrossOriginIsolationKey coi_a(
|
|
origin_a, CrossOriginIsolationMode::kConcrete);
|
|
AgentClusterKey::CrossOriginIsolationKey coi_b(
|
|
origin_b, CrossOriginIsolationMode::kConcrete);
|
|
AgentClusterKey::CrossOriginIsolationKey non_coi_a(
|
|
origin_a, CrossOriginIsolationMode::kLogical);
|
|
AgentClusterKey::CrossOriginIsolationKey non_coi_b(
|
|
origin_b, CrossOriginIsolationMode::kLogical);
|
|
|
|
EXPECT_EQ(coi_a, coi_a);
|
|
EXPECT_EQ(non_coi_a, non_coi_a);
|
|
EXPECT_NE(coi_a, coi_b);
|
|
EXPECT_NE(coi_a, non_coi_a);
|
|
EXPECT_NE(non_coi_a, non_coi_b);
|
|
|
|
AgentClusterKey key_origin_a_coi_a =
|
|
AgentClusterKey::CreateWithCrossOriginIsolationKey(origin_a, coi_a);
|
|
AgentClusterKey key_origin_b_coi_a =
|
|
AgentClusterKey::CreateWithCrossOriginIsolationKey(origin_b, coi_a);
|
|
AgentClusterKey key_origin_a_coi_b =
|
|
AgentClusterKey::CreateWithCrossOriginIsolationKey(origin_a, coi_b);
|
|
AgentClusterKey key_origin_a_non_coi_a =
|
|
AgentClusterKey::CreateWithCrossOriginIsolationKey(origin_a, non_coi_a);
|
|
|
|
EXPECT_EQ(key_origin_a_coi_a, key_origin_a_coi_a);
|
|
EXPECT_NE(key_origin_a_coi_a, key_origin_b_coi_a);
|
|
EXPECT_NE(key_origin_a_coi_a, key_origin_a_coi_b);
|
|
EXPECT_NE(key_origin_a_coi_a, key_origin_a_non_coi_a);
|
|
EXPECT_NE(key_origin_a_coi_a, key_origin_a);
|
|
EXPECT_NE(key_origin_a_coi_a, key_site_a);
|
|
EXPECT_NE(key_origin_a_non_coi_a, key_origin_a);
|
|
EXPECT_NE(key_origin_a_non_coi_a, key_site_a);
|
|
}
|
|
|
|
TEST_F(AgentClusterKeyTest, StreamOutput) {
|
|
std::stringstream dump;
|
|
GURL url_a("https://a.com");
|
|
url::Origin origin_a = url::Origin::Create(url_a);
|
|
url::Origin origin_b = url::Origin::Create(GURL("https://b.com"));
|
|
|
|
AgentClusterKey key_site_a = AgentClusterKey::CreateSiteKeyed(url_a);
|
|
dump << key_site_a;
|
|
EXPECT_EQ(dump.str(), "{site_: https://a.com/}");
|
|
dump.str("");
|
|
|
|
AgentClusterKey key_origin_a = AgentClusterKey::CreateOriginKeyed(origin_a);
|
|
dump << key_origin_a;
|
|
EXPECT_EQ(dump.str(), "{origin_: https://a.com}");
|
|
dump.str("");
|
|
|
|
AgentClusterKey key_origin_a_coi_b =
|
|
AgentClusterKey::CreateWithCrossOriginIsolationKey(
|
|
origin_a, AgentClusterKey::CrossOriginIsolationKey(
|
|
origin_b, CrossOriginIsolationMode::kConcrete));
|
|
dump << key_origin_a_coi_b;
|
|
EXPECT_EQ(dump.str(),
|
|
"{origin_: https://a.com, cross_origin_isolation_key_: "
|
|
"{common_coi_origin: "
|
|
"https://b.com, cross_origin_isolation_mode: concrete}}");
|
|
dump.str("");
|
|
}
|
|
|
|
} // namespace content
|