
This reverts commit06638b5897
. Reason for revert: We don't want LUCI culprit detection revert changes due to the Android ASAN dbg bot, compare crbug.com/1486663. Added NOAUTOREVERT=true to the commit message after instructions from https://bugs.chromium.org/p/chromium/issues/detail?id=1486663#c35 Original change's description: > Revert "[Fontations] Enable Fontations on Android" > > This reverts commit6c1a3d6662
. > > Reason for revert: > LUCI Bisection has identified this change as the culprit of a build failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/compile-analysis/b/8766155630578078161 > > Sample failed build: https://ci.chromium.org/b/8766155630578078161 > > If this is a false positive, please report it at https://bugs.chromium.org/p/chromium/issues/entry?comment=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Fcompile-analysis%2Fb%2F8766155630578078161&components=Tools%3ETest%3EFindit&labels=LUCI-Bisection-Wrong%2CPri-3%2CType-Bug&status=Available&summary=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F4978639 > > Original change's description: > > [Fontations] Enable Fontations on Android > > > > After the conflicting ASAN bot has been disabled or at least does not > > block the build anymore (see https://crbug.com/1486663), reland support > > for Android as a follow-up to https://crrev.com/1214748. > > > > Repeating binary size increase reasoning from https://crrev.com/1214748: > > This change introduces a temporary binary size increase, during which we > > need both Fontation and FreeType in the binary. When we complete the > > transition to Fontations we plan to remove FreeType and free up its used > > binary size footprint. See internal design doc or BlinkOn 18 talk on the > > Rust font stack for Chrome. > > > > Bug: 1446251 > > Binary-Size: See commit message. > > Fuchsia-Binary-Size: See commit message. > > Change-Id: I740dc28d384a98d0dc464dec1020f3bb54820465 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4978639 > > Reviewed-by: danakj <danakj@chromium.org> > > Commit-Queue: Dominik Röttsches <drott@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1215570} > > > > Bug: 1446251 > Change-Id: Ide025371200c7315ad74315d2cfc22746c8cda6d > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4981089 > Bot-Commit: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Owners-Override: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Commit-Queue: luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#1215704} NOAUTOREVERT=true Bug: 1446251 Binary-Size: See commit message. Change-Id: I52742e7f28f647976060759ffde8ecda9fc3800e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4982286 Auto-Submit: Dominik Röttsches <drott@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Reviewed-by: danakj <danakj@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/main@{#1218143}
About
//build
contains:
- Core GN templates and configuration
- Core Python build scripts
Since this directory is DEPS'ed in by some other repositories (webrtc, pdfium,
v8, etc), it should be kept as self-contained as possible by not referring
to files outside of it. Some exceptions exist (//testing
, select
//third_party
subdirectories), but new dependencies tend to break these other
projects, and so should be avoided.
Changes to //build
should be landed in the Chromium repo. They will then be
replicated to the stand-alone build repo
by the gsubtreed tool.
Note: You can find all directories already available through gsubtreed in the
list of all chromium repos.
Contents
//build/config
- Common templates via.gni
files.//build/toolchain
- GN toolchain definitions.Other .py files
- Some are used by GN/Ninja. Some by gclient hooks, some are just random utilities.
Files referenced by //.gn
:
//build/BUILDCONFIG.gn
- Included by allBUILD.gn
files.//build/secondary
- An overlay forBUILD.gn
files. Enables addingBUILD.gn
to directories that live in sub-repositories.//build_overrides
- Refer to //build_overrides/README.md.