0
Files
src/pdf
Tommy Nyquist 353a28e224 Revert "Fix PDF viewer jumping immediately after the user presses 'ctrl+f'"
This reverts commit 143885f9e5.

Reason for revert: Speculative revert for flaky test.
See https://crbug.com/1362116 for details.

Original change's description:
> Fix PDF viewer jumping immediately after the user presses 'ctrl+f'
>
> This behavior is disruptive and inconsistent with the search behavior
> of non-PDF sites. After this commit, pressing 'ctrl+f' will not start
> a search until the user presses additional keys (add characters /
> press enter).
>
> This bug is a side effect of fixing another bug "Chrome PDF Search is
> not executed in background" (crbug.com/764635). The fix reverts the
> changes done by the previous bug fix (pdfium_engine.cc) and provides an
> alternative solution (find_request_manager.cc) which requires to update
> some tests (pdf_find_request_manager_browsertest.cc,
> find_request_manager_browsertest.cc, findtext_unittest.cc).
>
> Lastly this is my first bug so I added my name to AUTHORS.
>
> Bug: 1290824
> Change-Id: I8e152087fb2ac019124e477b4d04d73d7b8f2f21
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3455153
> Commit-Queue: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Joey Arhar <jarhar@chromium.org>
> Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1043764}

Bug: 1290824, 1362116
Change-Id: I43366129df4a9e44b5413852a029c3a121f8590e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3888066
Owners-Override: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1045406}
2022-09-09 23:16:08 +00:00
..
2022-06-28 02:44:28 +00:00
2022-08-23 19:25:25 +00:00
2022-06-13 20:59:20 +00:00

//pdf contains the PDF plugin, its Blink-based replacement, as well as PDF utility functions that leverage PDFium. It can use low-level components that live below the content layer, as well as other foundational code like //printing. It should not use //content or anything in //components that lives above the content layer. Code that lives above the content layer should live in //components/pdf, or in the embedder. All the code here should run in sandboxed child processes.

TODO(crbug.com/1220865): Remove existing //content dependencies.