
In case of disk/access error FileURLLoader called ContentVerifyJob::DoneReading twice: (the first time from FileURLLoaderObserver::OnOpenComplete and the second time from FileURLLoaderObserver::OnDoneReading). This CL: 1. Move calling OnBytesRead+OnDoneReading for bad files to file_url_loader_factory; 2. Remove FileURLLoaderObserver::OnOpenComplete method; 3. Add DCHECKs in ContentVerifyJob so that we make sure OnDoneReading isn't called more than once. This also makes existing tests (e.g. ExtensionProtocolsTest.VerificationSeenForFileAccessErrors) serve as regression tests. TEST=unit_tests.ExtensionProtocolsTest.VerificationSeenForFileAccessErrors Change-Id: Ib91ecb7eaa5dad760068201903758df3f651dc5b Reviewed-on: https://chromium-review.googlesource.com/999484 Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by: Nick Carter <nick@chromium.org> Commit-Queue: Mikhail Atuchin <atuchin@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#552158}
This will become a reusable extensions module. It implements the core parts of Chrome's extension system, and can be used with any host of the content module.
Some extensions code that is not Chrome-specific still lives in //chrome/browser/extensions and will be moved here.
Technical Documentation: