AttemptManager has CHECK to ensure there is no available SpdySession
when attempting a TCP-based connection. It used
SpdySessionPool::HasAvailableSession() for the check. However, the
method didn't consider whether to enable or disable IP-based pooling.
The method could return true when there was an aliased SpdySession, even
when we disabled IP-based pooling, resulting in hitting CHECK failure.
This CL modifies HasAvailableSession() to take a flag that indicate
whether IP-based pooling is enabled or disabled. The method returns
false if IP-based pooling is disabled even when there is an aliased
SpdySession, in a way similar to FindAvailableSession().
Update HttpNetworkTransactionTest.RetryWithoutConnectionPooling
test to keep the first SpdySession to cover this case (Previously
the first SpdySession was closed before the second SpdySession
was created). Also use some actual NetLog sources so that we can
see NetLog events when `--log-net-log` command line flag is
specified (useful for debugging).
Bug: 397322724
Change-Id: Id52495d297661d2acce19c19057f6c5b25920fa8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6284467
Reviewed-by: mmenke <mmenke@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1424264}
cf6f56623e