c9dad5877d
This introduces a new class, UniqueCookieKey, to replace 4 distinct tuple aliases: StrictlyUniqueCookieKey, UniqueCookieKey, UniqueDomainCookieKey, and LegacyUniqueCookieKey. Turning these into dedicated types (rather than just aliases of tuples) has a few notable consequences: * Member accesses are more readable and maintainable, e.g. `signature.domain()` instead of `std::get<2>(signature)`. * CookieMonster's duplicate filtering logic no longer needs to be aware of host cookies vs domain cookies; it can just call UniqueKey() which will do the right thing instead of requiring the caller to know how to branch correctly. * We can now merge CookieBase::UniqueKey() and CookieBase::UniqueDomainKey() into a single function that is aware of what kind of key it should create. * We can now guarantee that these keys can only be created via the accessors in CookieBase. * The type system can no longer guarantee the usage of a Legacy key instead of a Strict key, or vice versa, since they're the same type. (This doesn't seem like a likely source of bugs to me, so I think this is fine. But we can also make Strict and Legacy keys their own types.) Fixed: 390345080 Change-Id: Iaebf4d34e854adbbfc4483ad4d2fc58794659199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6175944 Reviewed-by: Steven Bingler <bingler@chromium.org> Auto-Submit: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: David Song <wintermelons@google.com> Reviewed-by: Maks Orlovich <morlovich@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Reviewed-by: Jood Hajeer <jood@google.com> Cr-Commit-Position: refs/heads/main@{#1407461}
fuchsia.web - Fuchsia WebEngine and Runners
This directory contains code related to the
fuchsia.web FIDL API.
Specifically, it contains the implementation of Fuchsia WebEngine and code
related to it, including the Runners that use it. Code in this
directory must not be used outside it and its subdirectories.
General information about Chromium on Fuchsia is here.
[TOC]
Code organization
Each of the following subdirectories contain code for a specific Fuchsia service:
./commoncontains code shared by both WebEngine and Runners../runnerscontains implementations of Fuchsiasys.runner../runners/castEnables the Fuchsia system to launch Cast applications.
./shellcontains WebEngineShell, a simple wrapper for launching URLs in WebEngine from the command line../webenginecontains the WebEngine implementation. WebEngine is an implementation offuchsia.webthat enables Fuchsia Components to render web content using Chrome's Content layer../webinstance_hostcontains code for WebEngine clients to directly instantiate a WebInstance Component (web_instance.cm) using the WebEngine package.
Test code
There are 3 major types of tests within this directory:
- Unit tests: Exercise a single class in isolation, allowing full control over the external environment of this class.
- Browser tests: Spawn a full browser process and its child processes. The test code is run inside the browser process, allowing for full access to the browser code - but not other processes.
- Integration tests: Exercise the published FIDL API of a Fuchsia Component. For
instance,
//fuchsia_web/webengine:web_engine_integration_testsmake use of the//fuchsia_web/webengine:web_enginecomponent. The test code runs in a separate process in a separate Fuchsia Component, allowing only access to the published API of the component under test.
Integration tests are more resource-intensive than browser tests, which are in turn more expensive than unit tests. Therefore, when writing new tests, it is preferred to write unit tests over browser tests over integration tests.
As a general rule, test-only code should live in the same directory as the code
under test with an explicit file name, either fake_*, test_*,
*_unittest.cc, *_ browsertest.cc or *_integration_test.cc.
Test code that is shared across Components should live in a dedicated ``test
directory. For example, the //fuchsia_web/webengine/test directory, which
contains code shared by all browser tests, and
//fuchsia_web/common/test, which contains code shared by tests for both
WebEngine and Runners.