0
Files
src/content/common/web_ui_loading_util.cc
Alex Yang 1a48591114 webui: Add crash key for Mojo pipe creation error
According to crash reports, the creation of this Mojo pipe occasionally
fails. Add this crash key to determine the failure reason.

Bug: 383228552
Change-Id: I975344cc7ae498c5db5079fd46f1845f0a199fb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6086498
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Yang <aycyang@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1395552}
2024-12-12 12:02:35 -08:00

129 lines
4.6 KiB
C++

// Copyright 2024 The Chromium Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "content/common/web_ui_loading_util.h"
#include "base/check.h"
#include "base/debug/crash_logging.h"
#include "base/types/expected.h"
#include "mojo/public/cpp/bindings/pending_remote.h"
#include "mojo/public/cpp/bindings/remote.h"
#include "net/http/http_byte_range.h"
#include "net/http/http_request_headers.h"
#include "net/http/http_util.h"
#include "services/network/public/mojom/url_loader.mojom.h"
#include "services/network/public/mojom/url_response_head.mojom.h"
namespace content {
namespace webui {
void CallOnError(
mojo::PendingRemote<network::mojom::URLLoaderClient> client_remote,
int error_code) {
mojo::Remote<network::mojom::URLLoaderClient> client(
std::move(client_remote));
network::URLLoaderCompletionStatus status;
status.error_code = error_code;
client->OnComplete(status);
}
base::expected<net::HttpByteRange, GetRequestedRangeError> GetRequestedRange(
const net::HttpRequestHeaders& headers) {
std::optional<std::string> range_header =
headers.GetHeader(net::HttpRequestHeaders::kRange);
if (!range_header) {
return base::unexpected(GetRequestedRangeError::kNoRanges);
}
std::vector<net::HttpByteRange> ranges;
if (!net::HttpUtil::ParseRangeHeader(*range_header, &ranges)) {
return base::unexpected(GetRequestedRangeError::kParseFailed);
}
if (ranges.size() > 1u) {
return base::unexpected(GetRequestedRangeError::kMultipleRanges);
}
return ranges[0];
}
bool SendData(
network::mojom::URLResponseHeadPtr headers,
mojo::PendingRemote<network::mojom::URLLoaderClient> client_remote,
std::optional<net::HttpByteRange> requested_range,
scoped_refptr<base::RefCountedMemory> bytes) {
// The use of MojoCreateDataPipeOptions below means we'll be using uint32_t
// for sizes / offsets.
if (!base::IsValueInRangeForNumericType<uint32_t>(bytes->size())) {
CallOnError(std::move(client_remote), net::ERR_INSUFFICIENT_RESOURCES);
return false;
}
uint32_t output_offset = 0;
size_t output_size = bytes->size();
if (requested_range) {
if (!requested_range->ComputeBounds(output_size)) {
CallOnError(std::move(client_remote),
net::ERR_REQUEST_RANGE_NOT_SATISFIABLE);
return false;
}
DCHECK(base::IsValueInRangeForNumericType<uint32_t>(
requested_range->first_byte_position()))
<< "Expecting ComputeBounds() to enforce it";
output_offset = requested_range->first_byte_position();
output_size = requested_range->last_byte_position() -
requested_range->first_byte_position() + 1;
}
MojoCreateDataPipeOptions options;
options.struct_size = sizeof(MojoCreateDataPipeOptions);
options.flags = MOJO_CREATE_DATA_PIPE_FLAG_NONE;
options.element_num_bytes = 1;
options.capacity_num_bytes = output_size;
mojo::ScopedDataPipeProducerHandle pipe_producer_handle;
mojo::ScopedDataPipeConsumerHandle pipe_consumer_handle;
MojoResult create_result = mojo::CreateDataPipe(
&options, pipe_producer_handle, pipe_consumer_handle);
if (create_result != MOJO_RESULT_OK) {
SCOPED_CRASH_KEY_NUMBER("WebUI", "mojo_CreateDataPipe_result",
create_result);
CHECK(false);
}
base::span<uint8_t> buffer;
MojoResult result = pipe_producer_handle->BeginWriteData(
output_size, MOJO_WRITE_DATA_FLAG_NONE, buffer);
CHECK_EQ(result, MOJO_RESULT_OK);
CHECK_GE(buffer.size(), output_size);
CHECK_LE(output_offset + output_size, bytes->size());
buffer.copy_prefix_from(
base::span(*bytes).subspan(output_offset, output_size));
result = pipe_producer_handle->EndWriteData(output_size);
CHECK_EQ(result, MOJO_RESULT_OK);
// For media content, |content_length| must be known upfront for data that is
// assumed to be fully buffered (as opposed to streamed from the network),
// otherwise the media player will get confused and refuse to play.
// Content delivered via chrome:// URLs is assumed fully buffered.
headers->content_length = output_size;
mojo::Remote<network::mojom::URLLoaderClient> client(
std::move(client_remote));
client->OnReceiveResponse(std::move(headers), std::move(pipe_consumer_handle),
std::nullopt);
network::URLLoaderCompletionStatus status(net::OK);
status.encoded_data_length = output_size;
status.encoded_body_length = output_size;
status.decoded_body_length = output_size;
client->OnComplete(status);
return true;
}
} // namespace webui
} // namespace content