0
Files
src/fuchsia_web
Dibyajyoti Pal 3de66adf4d [PWA] Allow WebContentsImpl::CreateNewWindow() to use new web contents
for loading url

This CL ensures that chrome::AddWebContents() always returns the web
contents in which navigation has happened via ::Navigate() all the
way to WebContentsImpl::CreateNewWindow(), during a new top level
creation.

This allows url loading in the web contents to be done via the same
LoadUrlParams that the blink layer initially sent to complete
navigation, leading to its properties still being maintained, which
is more secure. Currently, the NavigationParams being created from
this function do not maintain that information, which could be
problematic.

This helps solve the following PWA navigation capturing use-case:
1. App A creates a new top level traversable of App B for url b.com
2. App B already has an open window with a launch_handling of
Navigate existing, in which case, App B's window is focussed.
3. Navigation to b.com/ happens in App B's window.

Currently, the navigation to url b.com/ does not accurately
populate all the LoadUrlParams, leading to dropped information. More
details are in https://docs.google.com/document/d/1a8NgBD26ovh3rqpt5QWMAI6wQ-V68OJoEtJ-W--cNMY/edit#heading=h.ybqtwkw0flyr

Bug: 359599878, 359600606, 351775835
Change-Id: I368119eb848259a4092a280c671b015dddcfde04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5791853
Reviewed-by: Zijie He <zijiehe@google.com>
Reviewed-by: Max Curran <curranmax@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Dibyajyoti Pal <dibyapal@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Kvitek <kvitekp@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1346275}
2024-08-23 23:34:03 +00:00
..

fuchsia.web - Fuchsia WebEngine and Runners

This directory contains code related to the fuchsia.web FIDL API. Specifically, it contains the implementation of Fuchsia WebEngine and code related to it, including the Runners that use it. Code in this directory must not be used outside it and its subdirectories.

General information about Chromium on Fuchsia is here.

[TOC]

Code organization

Each of the following subdirectories contain code for a specific Fuchsia service:

  • ./common contains code shared by both WebEngine and Runners.
  • ./runnerscontains implementations of Fuchsia sys.runner.
    • ./runners/cast Enables the Fuchsia system to launch Cast applications.
  • ./shell contains WebEngineShell, a simple wrapper for launching URLs in WebEngine from the command line.
  • ./webengine contains the WebEngine implementation. WebEngine is an implementation of fuchsia.web that enables Fuchsia Components to render web content using Chrome's Content layer.
  • ./webinstance_host contains code for WebEngine clients to directly instantiate a WebInstance Component (web_instance.cm) using the WebEngine package.

Test code

There are 3 major types of tests within this directory:

  • Unit tests: Exercise a single class in isolation, allowing full control over the external environment of this class.
  • Browser tests: Spawn a full browser process and its child processes. The test code is run inside the browser process, allowing for full access to the browser code - but not other processes.
  • Integration tests: Exercise the published FIDL API of a Fuchsia Component. For instance, //fuchsia_web/webengine:web_engine_integration_tests make use of the //fuchsia_web/webengine:web_engine component. The test code runs in a separate process in a separate Fuchsia Component, allowing only access to the published API of the component under test.

Integration tests are more resource-intensive than browser tests, which are in turn more expensive than unit tests. Therefore, when writing new tests, it is preferred to write unit tests over browser tests over integration tests.

As a general rule, test-only code should live in the same directory as the code under test with an explicit file name, either fake_*, test_*, *_unittest.cc, *_ browsertest.cc or *_integration_test.cc.

Test code that is shared across Components should live in a dedicated ``test directory. For example, the //fuchsia_web/webengine/test directory, which contains code shared by all browser tests, and //fuchsia_web/common/test, which contains code shared by tests for both WebEngine and Runners.