4e1b7bc33d
The methodology used to generate this CL is documented in https://crbug.com/1098010#c34. No-Try: true No-Presubmit: true Bug: 1098010 Change-Id: I8c0f009d16350271f07d8e5e561085822cc9dd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3895935 Owners-Override: Avi Drissman <avi@chromium.org> Reviewed-by: Mark Mentovai <mark@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1047456}
110 lines
4.0 KiB
C++
110 lines
4.0 KiB
C++
// Copyright 2017 The Chromium Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "content/browser/browser_main_loop.h"
|
|
|
|
#include "base/command_line.h"
|
|
#include "base/system/sys_info.h"
|
|
#include "base/task/thread_pool/thread_pool_instance.h"
|
|
#include "base/test/mock_callback.h"
|
|
#include "base/test/scoped_command_line.h"
|
|
#include "content/browser/browser_thread_impl.h"
|
|
#include "content/browser/scheduler/browser_task_executor.h"
|
|
#include "content/browser/startup_data_impl.h"
|
|
#include "content/browser/startup_helper.h"
|
|
#include "content/public/browser/browser_thread.h"
|
|
#include "content/public/common/content_switches.h"
|
|
#include "content/public/common/main_function_params.h"
|
|
#include "content/public/test/test_utils.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace content {
|
|
|
|
using StrickMockTask =
|
|
testing::StrictMock<base::MockCallback<base::RepeatingCallback<void()>>>;
|
|
|
|
class BrowserMainLoopTest : public testing::Test {
|
|
protected:
|
|
BrowserMainLoopTest() {
|
|
base::test::ScopedCommandLine scoped_command_line;
|
|
scoped_command_line.GetProcessCommandLine()->AppendSwitch(
|
|
switches::kSingleProcess);
|
|
base::ThreadPoolInstance::Create("Browser");
|
|
StartBrowserThreadPool();
|
|
BrowserTaskExecutor::Create();
|
|
}
|
|
|
|
~BrowserMainLoopTest() override {
|
|
BrowserTaskExecutor::ResetForTesting();
|
|
for (int id = BrowserThread::UI; id < BrowserThread::ID_COUNT; ++id) {
|
|
BrowserThreadImpl::ResetGlobalsForTesting(
|
|
static_cast<BrowserThread::ID>(id));
|
|
}
|
|
base::ThreadPoolInstance::Get()->JoinForTesting();
|
|
base::ThreadPoolInstance::Set(nullptr);
|
|
}
|
|
|
|
const base::CommandLine* GetProcessCommandLine() {
|
|
return scoped_command_line_.GetProcessCommandLine();
|
|
}
|
|
|
|
private:
|
|
base::test::ScopedCommandLine scoped_command_line_;
|
|
}; // namespace content
|
|
|
|
// Verify that a single-process browser process has at least as many threads as
|
|
// the number of cores in its foreground pool.
|
|
TEST_F(BrowserMainLoopTest, CreateThreadsInSingleProcess) {
|
|
MainFunctionParams main_function_params(GetProcessCommandLine());
|
|
|
|
auto startup_data = std::make_unique<StartupDataImpl>();
|
|
startup_data->io_thread = BrowserTaskExecutor::CreateIOThread();
|
|
main_function_params.startup_data = std::move(startup_data);
|
|
|
|
BrowserMainLoop browser_main_loop(
|
|
std::move(main_function_params),
|
|
std::make_unique<base::ThreadPoolInstance::ScopedExecutionFence>());
|
|
browser_main_loop.Init();
|
|
browser_main_loop.CreateMainMessageLoop();
|
|
browser_main_loop.CreateThreads();
|
|
EXPECT_GE(base::ThreadPoolInstance::Get()
|
|
->GetMaxConcurrentNonBlockedTasksWithTraitsDeprecated(
|
|
{base::TaskPriority::USER_VISIBLE}),
|
|
static_cast<size_t>(base::SysInfo::NumberOfProcessors() - 1));
|
|
browser_main_loop.ShutdownThreadsAndCleanUp();
|
|
BrowserTaskExecutor::ResetForTesting();
|
|
}
|
|
|
|
TEST_F(BrowserMainLoopTest,
|
|
PostTaskToIOThreadBeforeThreadCreationDoesNotRunTask) {
|
|
MainFunctionParams main_function_params(GetProcessCommandLine());
|
|
|
|
auto startup_data = std::make_unique<StartupDataImpl>();
|
|
startup_data->io_thread = BrowserTaskExecutor::CreateIOThread();
|
|
main_function_params.startup_data = std::move(startup_data);
|
|
|
|
BrowserMainLoop browser_main_loop(
|
|
std::move(main_function_params),
|
|
std::make_unique<base::ThreadPoolInstance::ScopedExecutionFence>());
|
|
browser_main_loop.Init();
|
|
browser_main_loop.CreateMainMessageLoop();
|
|
|
|
StrickMockTask task;
|
|
|
|
// No task should run because IO thread has not been initialized yet.
|
|
GetIOThreadTaskRunner({})->PostTask(FROM_HERE, task.Get());
|
|
GetIOThreadTaskRunner({})->PostTask(FROM_HERE, task.Get());
|
|
|
|
content::RunAllPendingInMessageLoop(BrowserThread::IO);
|
|
|
|
EXPECT_CALL(task, Run).Times(2);
|
|
browser_main_loop.CreateThreads();
|
|
content::RunAllPendingInMessageLoop(BrowserThread::IO);
|
|
|
|
browser_main_loop.ShutdownThreadsAndCleanUp();
|
|
BrowserTaskExecutor::ResetForTesting();
|
|
}
|
|
|
|
} // namespace content
|