0
Files
src/remoting
Caleb Raitto aa907661b5 Reland "Clickiness: Wire response from URLLoader to DB, add e2e tests"
This reverts commit bcc9fcd9e7.

Reason for revert: Fixed ubsan failures
The fix diff can be reviewed here: crrev.com/c/6360858/1..2

Original change's description:
> Revert "Clickiness: Wire response from URLLoader to DB, add e2e tests"
>
> This reverts commit c321aa7496.
>
> Reason for revert:
> LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/4996809668689920
>
> Sample build with failed test: https://ci.chromium.org/b/8720390641933726001
> Affected test(s):
> [ninja://chrome/test:unit_tests/CRLSetComponentInstallerTest.ConfiguresOnInstall](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:unit_tests%2FCRLSetComponentInstallerTest.ConfiguresOnInstall?q=VHash%3A799aae891109c818)
> [ninja://chrome/test:unit_tests/CRLSetComponentInstallerTest.StillConfiguredAfterNetworkServiceRestartWithCRLSet](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:unit_tests%2FCRLSetComponentInstallerTest.StillConfiguredAfterNetworkServiceRestartWithCRLSet?q=VHash%3A799aae891109c818)
> [ninja://chrome/test:unit_tests/DevToolsUIDataSourceWithTaskEnvTest.GotDataCallbackOwnsDevToolsDataSource](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:unit_tests%2FDevToolsUIDataSourceWithTaskEnvTest.GotDataCallbackOwnsDevToolsDataSource?q=VHash%3A799aae891109c818)
> [ninja://chrome/test:unit_tests/EmbeddedPolicyTestServerTest.HandleRequest_Success](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:unit_tests%2FEmbeddedPolicyTestServerTest.HandleRequest_Success?q=VHash%3A799aae891109c818)
> [ninja://chrome/test:unit_tests/PerformNetworkContextPrefetchRecorderTest.Style](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:unit_tests%2FPerformNetworkContextPrefetchRecorderTest.Style?q=VHash%3A799aae891109c818)
> and 7 more ...
>
> If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F4996809668689920&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6336937&type=BUG
>
> Original change's description:
> > Clickiness: Wire response from URLLoader to DB, add e2e tests
> >
> > Checking if origins are allowed (allowed by user settings, attested,
> > etc.) will come in a subsequent CL.
> >
> > Doesn't include the redirection logic -- that will land in crrev.com/c/6353624.
> >
> > Bug: 394108643
> > Change-Id: Ic3897262c17afa7a7cbae967b9f266277ea77a80
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6336937
> > Auto-Submit: Caleb Raitto <caraitto@chromium.org>
> > Commit-Queue: Yuwei Huang <yuweih@chromium.org>
> > Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> > Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Reviewed-by: Yuwei Huang <yuweih@chromium.org>
> > Reviewed-by: Austin Sullivan <asully@chromium.org>
> > Reviewed-by: Ken Buchanan <kenrb@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1432935}
> >
>
> Bug: 394108643
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: Iab03915999352e60653433ae4f460df9effdd323
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6356884
> Commit-Queue: Austin Sullivan <asully@chromium.org>
> Owners-Override: Austin Sullivan <asully@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Reviewed-by: Austin Sullivan <asully@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1433038}

Bug: 394108643
Fixed: 403652961
Change-Id: Ic6eb6bee6008e67afe247f28131ff8ce347074ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6360858
Reviewed-by: Yuwei Huang <yuweih@chromium.org>
Reviewed-by: Austin Sullivan <asully@chromium.org>
Auto-Submit: Caleb Raitto <caraitto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Commit-Queue: Caleb Raitto <caraitto@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1434209}
2025-03-18 09:48:53 -07:00
..
2025-02-02 23:30:48 -08:00
2025-02-02 23:30:48 -08:00