
Implement the annotation brush type selection in the frontend of the PDF viewer. It will send a setAnnotationBrush message to the backend to tell it what type, color, and size of brush to set the annotation brush to. This uses the existing annotation bar UI from CrOS's annotation mode. Some types of brushes shouldn't need a color or size, such as the eraser. This is reflected in AnnotationBrushParams, where either all values must be set or the params should be missing completely. There is a slight difference in behavior from the new annotation mode and the existing CrOS annotation mode: normally, the annotation tool would be updated every time the annotation menu was clicked, even if the values didn't change. The new annotation mode shouldn't do this, otherwise it will send many messages to the backend. Bug: 335521186 Change-Id: Ib909927d2d8e6a132c867eafc3d3feadd2cd7c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5540210 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Andy Phan <andyphan@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/main@{#1301653}
Chrome
This directory contains the open source, application layer of Google Chrome.
Unlike other parts of Chromium like //content, which provide framework intended to support multiple products, this directory contains code that is focused on building specific products with opinionated UX.
Specific products include:
- Chrome desktop browser for Chrome OS, Windows, Mac and Linux
- Chrome mobile browser for Android
- Chrome OS system UI
See //ios/chrome for the Chrome mobile browser for iOS, and note that code that is shared between //chrome and //ios/chrome is typically factored out into //components.