
The PEPC element needs to get the overall permission status including the device status in order to correctly decide which text to present to the user. This CL ensures that the PEPC observer will receive the permission status including the device status, while not changing the functionality for other observers. This is done by adding a new parameter to the `AddObserver` call: `should_include_device_status`. This parameter is trickled all the way down to the `PermissionManager` where it is used when calculating the permission status for that subscription only, whenever that is done. *Reviewers*: This CL makes mechanical changes to many files, but the only logical changes are: * chrome_permissions_client.cc - implement OS device status interaction for Mac * components/permissions/permission_context_base.h - define new `AlwaysIncludeDeviceStatus` function which allows the `GeolocationPermissionContextAndroid` to keep its current functionality * `components/permissions/permission_manager.cc` - use the new `should_include_device_status` parameter to decide whether to include the device status when getting the permission status. * html_permission_element.cc - make the AddObserver call with `should_include_device_status` = true Fixed: 335834559 Change-Id: Ia8cf68010c9b596520a6b4c5fc61ad24577452f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5483406 Reviewed-by: Peter Beverloo <peter@chromium.org> Reviewed-by: David Song <wintermelons@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Peter Kvitek <kvitekp@chromium.org> Reviewed-by: Thomas Nguyen <tungnh@chromium.org> Reviewed-by: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by: Sean Topping <seantopping@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Reviewed-by: Mason Freed <masonf@chromium.org> Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/main@{#1299563}
fuchsia.web
- Fuchsia WebEngine and Runners
This directory contains code related to the
fuchsia.web
FIDL API.
Specifically, it contains the implementation of Fuchsia WebEngine and code
related to it, including the Runners that use it. Code in this
directory must not be used outside it and its subdirectories.
General information about Chromium on Fuchsia is here.
[TOC]
Code organization
Each of the following subdirectories contain code for a specific Fuchsia service:
./common
contains code shared by both WebEngine and Runners../runners
contains implementations of Fuchsiasys.runner
../runners/cast
Enables the Fuchsia system to launch Cast applications.
./shell
contains WebEngineShell, a simple wrapper for launching URLs in WebEngine from the command line../webengine
contains the WebEngine implementation. WebEngine is an implementation offuchsia.web
that enables Fuchsia Components to render web content using Chrome's Content layer../webinstance_host
contains code for WebEngine clients to directly instantiate a WebInstance Component (web_instance.cm
) using the WebEngine package.
Test code
There are 3 major types of tests within this directory:
- Unit tests: Exercise a single class in isolation, allowing full control over the external environment of this class.
- Browser tests: Spawn a full browser process and its child processes. The test code is run inside the browser process, allowing for full access to the browser code - but not other processes.
- Integration tests: Exercise the published FIDL API of a Fuchsia Component. For
instance,
//fuchsia_web/webengine:web_engine_integration_tests
make use of the//fuchsia_web/webengine:web_engine
component. The test code runs in a separate process in a separate Fuchsia Component, allowing only access to the published API of the component under test.
Integration tests are more resource-intensive than browser tests, which are in turn more expensive than unit tests. Therefore, when writing new tests, it is preferred to write unit tests over browser tests over integration tests.
As a general rule, test-only code should live in the same directory as the code
under test with an explicit file name, either fake_*
, test_*
,
*_unittest.cc
, *_ browsertest.cc
or *_integration_test.cc
.
Test code that is shared across Components should live in a dedicated ``test
directory. For example, the //fuchsia_web/webengine/test
directory, which
contains code shared by all browser tests, and
//fuchsia_web/common/test
, which contains code shared by tests for both
WebEngine and Runners.