0
Files
src/ui
Scott Violet b9aea738ca Revert "Unify TestScreen usages across aura and Mac"
This reverts commit 793e3a1c27.

Reason for revert: This has resulted in a lot of random flake. See https://bugs.chromium.org/p/chromium/issues/detail?id=1219461 . I believe the core issue is that test code is now destroying Screens before other code may be trying to access it. This leads to the possibility of a uaf. For the PageInfoBubbleView tests, this is now the case. Unfortunately the destructor of TestWebContentsFactory calls RunUntilIdle, which is why the failure is not always consistent.

Original change's description:
> Unify TestScreen usages across aura and Mac
>
> This CL mainly did the following changes:
> -- Add a TestScreenMac in ViewsTestHelperMac;
> -- Change aura::TestScreen to also inherit from display::TestScreen;
> -- Remove some unnecessay test screen overrides to make tests work;
> -- Re-enable one LinkTest
>
> More details about these changes are in https://bit.ly/3yjxheL
>
> Fixed: 1071633
> Change-Id: Ia8ad7706ff3c6fce7f1b6ffc9e72e538bd89b6aa
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2898843
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Reviewed-by: Mike Wasserman <msw@chromium.org>
> Commit-Queue: Wei Li <weili@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#891841}

Change-Id: I60d5e23fa76a57f15607edea4bada981d21c51cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2959780
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Scott Violet <sky@chromium.org>
Owners-Override: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#892227}
2021-06-14 19:57:40 +00:00
..
2021-06-14 16:25:11 +00:00
2021-05-18 06:43:27 +00:00
2021-06-02 15:29:31 +00:00

This directory contains UI frameworks used to build various user interface features. This directory it not intended to contain UI features (such as a keyboard).