0
Files
src/build/PRESUBMIT.py
Takuto Ikuta 40def48455 PRESUBMIT.py: remove USE_PYTHON3 = True
presubmit now uses python3 only.

This is generated by
$ rg -l '^USE_PYTHON3 = True' | \
  xargs sed -z -i "s/\n*USE_PYTHON3 = True\n*/\n\n/"
with some more modifications.

This also removes run_on_python2, run_on_python3, and skip_shebang_check
args.

Bug: 1207012
Change-Id: I8c842d0a9ac485a27399d704a17b755f58a64db8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4573952
Reviewed-by: Nico Weber <thakis@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Owners-Override: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1152319}
2023-06-02 02:23:49 +00:00

56 lines
2.0 KiB
Python

# Copyright 2022 The Chromium Authors
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
PRESUBMIT_VERSION = '2.0.0'
import textwrap
def CheckNoBadDeps(input_api, output_api):
"""Prevent additions of bad dependencies from the //build prefix."""
build_file_patterns = [
r'(.+/)?BUILD\.gn',
r'.+\.gni',
]
exclude_file_patterns = [
r'build/rust/tests',
]
blocklist_pattern = input_api.re.compile(r'^[^#]*"//(?!build).+?/.*"')
allowlist_pattern = input_api.re.compile(r'^[^#]*"//third_party/junit')
warning_message = textwrap.dedent("""
The //build directory is meant to be as hermetic as possible so that
other projects (webrtc, v8, angle) can make use of it. If you are adding
a new dep from //build onto another directory, you should consider:
1) Can that dep live within //build?
2) Can the dep be guarded by "build_with_chromium"?
3) Have you made this new dep easy to pull in for other projects (ideally
a matter of adding a DEPS entry).:""")
def FilterFile(affected_file):
return input_api.FilterSourceFile(affected_file,
files_to_check=build_file_patterns,
files_to_skip=exclude_file_patterns)
problems = []
for f in input_api.AffectedSourceFiles(FilterFile):
local_path = f.LocalPath()
for line_number, line in f.ChangedContents():
if blocklist_pattern.search(line) and not allowlist_pattern.search(line):
problems.append('%s:%d\n %s' %
(local_path, line_number, line.strip()))
if problems:
return [output_api.PresubmitPromptOrNotify(warning_message, problems)]
else:
return []
def CheckPythonTests(input_api, output_api):
return input_api.RunTests(
input_api.canned_checks.GetUnitTestsInDirectory(
input_api,
output_api,
input_api.PresubmitLocalPath(),
files_to_check=[r'.+_(?:unit)?test\.py$']))