a8c0dedd37
It's a bit flaky on the bots: https://ci.chromium.org/ui/p/chromium/builders/try/chromium_presubmit/3085167/overview Bug: None Change-Id: I429d18fec0151f386b1652f21331e41b6682cedc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6111793 Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/main@{#1399255}
149 lines
5.4 KiB
Python
149 lines
5.4 KiB
Python
# Copyright 2013 The Chromium Authors
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
"""Presubmit script for android buildbot.
|
|
|
|
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
|
|
details on the presubmit API built into depot_tools.
|
|
"""
|
|
|
|
|
|
|
|
def CommonChecks(input_api, output_api, *, is_upload):
|
|
# These tools don't run on Windows so these tests don't work and give many
|
|
# verbose and cryptic failure messages. Linting the code is also skipped on
|
|
# Windows because it will fail due to os differences.
|
|
if input_api.sys.platform == 'win32':
|
|
return []
|
|
|
|
build_android_dir = input_api.PresubmitLocalPath()
|
|
|
|
def J(*dirs):
|
|
"""Returns a path relative to presubmit directory."""
|
|
return input_api.os_path.join(build_android_dir, *dirs)
|
|
|
|
build_pys = [
|
|
r'gn/.*\.py$',
|
|
r'gyp/.*\.py$',
|
|
]
|
|
tests = []
|
|
# yapf likes formatting the extra_paths_list to be less readable.
|
|
# yapf: disable
|
|
tests.extend(
|
|
input_api.canned_checks.GetPylint(
|
|
input_api,
|
|
output_api,
|
|
pylintrc='pylintrc',
|
|
files_to_skip=[
|
|
r'.*_pb2\.py'
|
|
] + build_pys,
|
|
extra_paths_list=[
|
|
J(),
|
|
J('gyp'),
|
|
J('buildbot'),
|
|
J('..', 'util'),
|
|
J('..', '..', 'third_party', 'catapult', 'common',
|
|
'py_trace_event'),
|
|
J('..', '..', 'third_party', 'catapult', 'common', 'py_utils'),
|
|
J('..', '..', 'third_party', 'catapult', 'devil'),
|
|
J('..', '..', 'third_party', 'catapult', 'tracing'),
|
|
J('..', '..', 'third_party', 'depot_tools'),
|
|
J('..', '..', 'third_party', 'colorama', 'src'),
|
|
J('..', '..', 'build'),
|
|
],
|
|
version='2.7'))
|
|
tests.extend(
|
|
input_api.canned_checks.GetPylint(
|
|
input_api,
|
|
output_api,
|
|
files_to_check=build_pys,
|
|
files_to_skip=[
|
|
r'.*_pb2\.py',
|
|
r'.*_pb2\.py',
|
|
r'.*create_unwind_table\.py',
|
|
r'.*create_unwind_table_tests\.py',
|
|
],
|
|
extra_paths_list=[J('gyp'), J('gn')],
|
|
version='2.7'))
|
|
|
|
tests.extend(
|
|
input_api.canned_checks.GetPylint(
|
|
input_api,
|
|
output_api,
|
|
files_to_check=[
|
|
r'.*create_unwind_table\.py',
|
|
r'.*create_unwind_table_tests\.py',
|
|
],
|
|
extra_paths_list=[J('gyp'), J('gn')],
|
|
version='2.7'))
|
|
# yapf: enable
|
|
|
|
pylib_test_env = dict(input_api.environ)
|
|
pylib_test_env.update({
|
|
'PYTHONPATH': build_android_dir,
|
|
'PYTHONDONTWRITEBYTECODE': '1',
|
|
})
|
|
|
|
pytests = [
|
|
J('.', 'list_class_verification_failures_test.py'),
|
|
J('.', 'convert_dex_profile_tests.py'),
|
|
J('gyp', 'compile_java_tests.py'),
|
|
J('gyp', 'create_unwind_table_tests.py'),
|
|
J('gyp', 'dex_test.py'),
|
|
J('gyp', 'extract_unwind_tables_tests.py'),
|
|
J('gyp', 'gcc_preprocess_tests.py'),
|
|
J('gyp', 'java_cpp_enum_tests.py'),
|
|
J('gyp', 'java_cpp_features_tests.py'),
|
|
J('gyp', 'java_cpp_strings_tests.py'),
|
|
J('gyp', 'java_google_api_keys_tests.py'),
|
|
J('gyp', 'util', 'build_utils_test.py'),
|
|
J('gyp', 'util', 'manifest_utils_test.py'),
|
|
J('gyp', 'util', 'md5_check_test.py'),
|
|
J('gyp', 'util', 'resource_utils_test.py'),
|
|
J('pylib', 'base', 'output_manager_test_case.py'),
|
|
J('pylib', 'constants', 'host_paths_unittest.py'),
|
|
J('pylib', 'gtest', 'gtest_test_instance_test.py'),
|
|
J('pylib', 'instrumentation', 'instrumentation_parser_test.py'),
|
|
J('pylib', 'instrumentation', 'instrumentation_test_instance_test.py'),
|
|
J('pylib', 'local', 'device', 'local_device_gtest_run_test.py'),
|
|
J('pylib', 'local', 'device',
|
|
'local_device_instrumentation_test_run_test.py'),
|
|
J('pylib', 'local', 'device', 'local_device_test_run_test.py'),
|
|
J('pylib', 'local', 'emulator', 'ini_test.py'),
|
|
J('pylib', 'local', 'machine', 'local_machine_junit_test_run_test.py'),
|
|
J('pylib', 'output', 'local_output_manager_test.py'),
|
|
J('pylib', 'output', 'noop_output_manager_test.py'),
|
|
J('pylib', 'output', 'remote_output_manager_test.py'),
|
|
J('pylib', 'results', 'flakiness_dashboard',
|
|
'json_results_generator_unittest.py'),
|
|
J('pylib', 'results', 'json_results_test.py'),
|
|
J('pylib', 'utils', 'chrome_proxy_utils_test.py'),
|
|
J('pylib', 'utils', 'code_coverage_utils_test.py'),
|
|
J('pylib', 'utils', 'decorators_test.py'),
|
|
J('pylib', 'utils', 'device_dependencies_test.py'),
|
|
J('pylib', 'utils', 'dexdump_test.py'),
|
|
J('pylib', 'utils', 'gold_utils_test.py'),
|
|
J('pylib', 'utils', 'test_filter_test.py'),
|
|
]
|
|
if is_upload:
|
|
pytests += [J('.', 'fast_local_dev_server_test.py')]
|
|
|
|
# Build server tests are flaky on bots.
|
|
# E.g.: https://ci.chromium.org/ui/p/chromium/builders/try/chromium_presubmit/3085167/overview
|
|
tests.extend(
|
|
input_api.canned_checks.GetUnitTests(input_api,
|
|
output_api,
|
|
unit_tests=pytests,
|
|
env=pylib_test_env))
|
|
|
|
return input_api.RunTests(tests)
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return CommonChecks(input_api, output_api, is_upload=True)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return CommonChecks(input_api, output_api, is_upload=False)
|