chromium/src
0
Fork 0
Code Activity
Files
4be7a00adf3daa3a91ac3453e69a08d603672c78
src/tools
History
Marc Treib e0dc9ebd01 History Sync: Don't upload foreign visits 
A syncing client should only ever upload its own visits to the server,
never those coming from other clients.
Generally, foreign visits should never get updated in the history DB
anyway (except through Sync), but it some cases it might happen (e.g.
data migrations/cleanups, or maybe just bugs elsewhere). In that case,
it's better not to upload any such changes, to avoid messing up other
clients.
This CL adds an appropriate check plus a unit test.

Bug: 1395826
Change-Id: I91491de0dc9d75d05534007f5d62a6edca805bff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4083546
Commit-Queue: Marc Treib <treib@chromium.org>
Auto-Submit: Marc Treib <treib@chromium.org>
Reviewed-by: Victor Vianna <victorvianna@google.com>
Commit-Queue: Victor Vianna <victorvianna@google.com>
Cr-Commit-Position: refs/heads/main@{#1080312}
2022-12-07 14:10:01 +00:00
..
accessibility
Replace std::copy_if() with base::ranges::copy_if().
2022-11-03 10:09:21 +00:00
aggregation_service
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
android
Android: Add target_view.html for dep analysis
2022-12-05 21:53:52 +00:00
attribution_reporting
Stop checking actual report times in attribution simulator tests
2022-12-02 18:04:15 +00:00
binary_size
[SuperSize] Viewer: Regenerate wasmbuild.patch.
2022-12-06 15:20:15 +00:00
bisect
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
bisect_repackage
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
browserbench-webdriver
browserbench: gets working on non-mac again
2022-11-28 21:49:17 +00:00
captured_sites
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
cast3p
Roll Cast Web Runtime from 328963 to 329228
2022-11-29 19:03:49 +00:00
cfi
…
check_ecs_deps
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
checkbins
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
checklicenses
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
checkperms
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
checkteamtags
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
chrome_extensions/open_my_editor
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
clang
[BRP] Generate const raw_ref instead of raw_ref
2022-12-06 09:41:09 +00:00
code_coverage
Stop using the six library in coverage.py.
2022-10-11 22:11:00 +00:00
compile_test
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
cr
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
crates
Enable rustfmt comment wrapping and reformat Rust code
2022-11-29 20:24:57 +00:00
crbug
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
cros
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
cygprofile
Reland "orderfile: add use_remoteexec support"
2022-10-28 13:15:27 +00:00
determinism
tools/determinism: drop Python2 support
2022-12-05 01:53:13 +00:00
diagnosis
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
disable_tests
VT: Rename DocumentTransition to ViewTransitions
2022-11-04 20:04:54 +00:00
dromaeo_benchmark_runner
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
dump_process_memory
[tools/memory] Record number of pointers from PA in dump_process tool
2022-11-17 03:35:02 +00:00
emacs
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
find_runtime_symbols
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
flags
Fix generate_unexpire_flags test expectations for base::Feature macros.
2022-10-03 15:04:06 +00:00
flakiness
tools/is_flaky.py: modernize from python2 to python3
2022-11-22 16:35:47 +00:00
fuchsia
[fuchsia] Raise size budget by 350kB to 41.22MiB
2022-09-27 18:54:51 +00:00
gdb
Fix gdb pretty printer for std::atomic
2022-11-01 21:42:05 +00:00
generate_library_loader
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
generate_shim_headers
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
generate_stubs
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
get_asan_chrome
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
get_swarming_logs
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
git
tools/git: modernize README to md, py files to python3, fix bash style
2022-11-28 22:15:34 +00:00
gn
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
grit
Introduce a GN boolean to control whether to use internal icons for Chrome for Testing
2022-11-15 20:01:35 +00:00
gritsettings
[Office upload] Add header images for the setup dialog
2022-11-30 02:45:52 +00:00
idl_parser
ShadowRealm: Implement ShadowRealm global object in Blink (6/N)
2022-11-30 13:49:02 +00:00
imagediff
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
infra
Delete tools/infra/reproduce.py
2022-10-12 17:52:09 +00:00
ipc_fuzzer
task posting v3: moving away from ThreadTaskRunnerHandle
2022-11-21 15:32:47 +00:00
json_comment_eater
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
json_data_generator
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
json_schema_compiler
Update Value usage in tools/json_schema_compiler.
2022-12-07 02:01:15 +00:00
json_to_struct
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
l10n
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
licenses
Fix //tools/licenses tests on Windows
2022-12-05 14:53:10 +00:00
linux
Reland "dump-static-initializers.py: Improve accuracy and output usefulness"
2022-10-14 01:12:00 +00:00
lldb
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
luci-go
…
mac
[power benchmarks] Add more logging.
2022-12-05 21:20:39 +00:00
mb
switch goma to reclient: windows in chrome
2022-12-07 02:16:19 +00:00
md_browser
Return dpranke to (some) OWNERS files.
2022-11-01 20:04:36 +00:00
media_engagement_preload
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
memory
Reland "[PA] Remove BUILDFLAG(USE_BACKUP_REF_PTR)"
2022-11-30 09:22:40 +00:00
metrics
History Sync: Don't upload foreign visits
2022-12-07 14:10:01 +00:00
msan
…
oopif
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
origin_trials
Add missing space to generate_token.py's version argument help
2022-10-04 18:01:18 +00:00
page_cycler
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
perf
Roll Perfetto Trace Processor Mac from bc5a6bdf2500 to d581ead87c2d
2022-12-07 02:02:51 +00:00
perfbot-analysis
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
polymer
WebUI: Move event_target and util to ash
2022-11-30 20:21:43 +00:00
privacy_budget
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
profiling
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
protoc_wrapper
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
python
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
real_world_impact
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
resources
Preserve IDs starting with 'EXPORT_' in svgo presubmit
2022-11-11 03:56:15 +00:00
resultdb
…
rust
Turn on code coverage generation for Rust code with use_clang_coverage
2022-11-28 21:24:51 +00:00
security
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
site_compare
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
stats_viewer
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
strict_enum_value_checker
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
style_variable_generator
Reenable DeletedCSSVariable presubmit & upgrade to presubmit 2.
2022-11-28 00:08:39 +00:00
sublime
Change ninja path in compile_current_file.py
2022-11-28 13:58:29 +00:00
symsrc
Update source-indexing instructions
2022-10-13 18:50:52 +00:00
traceline
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
tracing
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
traffic_annotation
[Safelist Removal] Permission Request Creator
2022-12-06 15:45:28 +00:00
translation
Make upload_screenshots recognize PNG
2022-11-23 23:53:37 +00:00
typescript
chrome.management: Migrate to Promise-based extension APIs
2022-12-07 00:48:36 +00:00
ubsan
…
usb_gadget
Deterministic output for usb_gadget packager
2022-11-30 17:48:23 +00:00
v8_context_snapshot
Move USE_V8_CONTEXT_SNAPSHOT from a define to a buildflag...
2022-11-30 03:48:39 +00:00
valgrind
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
variations
[code-health] Remove references to vpython in /tools/variations
2022-09-19 22:05:26 +00:00
vim
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
visual_debugger
Visual Debugger UI tweaks
2022-11-23 22:36:02 +00:00
vscode
Add extensions and ash unit tests to "build test" task
2022-11-08 21:45:00 +00:00
web_bluetooth
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
web_dev_style
Optimize AddedJsFilesCheck
2022-12-02 00:39:07 +00:00
win
Update instructions to current version of Visual Studio
2022-10-20 18:43:09 +00:00
.gitignore
…
.style.yapf
…
add_header_test.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
add_header.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
apply_cpplint_header_guard.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
auto-nav.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
autotest.py
Support gtest-filter and gtest_filter with autotest.py
2022-11-30 02:37:52 +00:00
bash-completion
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
bisect_test.py
Disable failing bisect test on Windows
2022-11-24 01:25:07 +00:00
bisect-builds.py
[bisect-builds] Avoid deprecation warnings
2022-11-16 08:09:36 +00:00
boilerplate.py
Reland "Add presubmit check to prevent new JavaScript in iOS directories"
2022-10-20 00:15:13 +00:00
buildstate.bat
…
buildstate.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
check_git_config.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
check_grd_for_unused_strings.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
clang-format-js
clang-format: support -h/--help to invoke usage
2022-11-18 21:05:38 +00:00
DEPS
…
diagnose-me.py
Migrate src/tools/diagnose-me.py to Python3.
2022-10-18 00:46:16 +00:00
DIR_METADATA
…
download_optimization_profile.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
hresult_to_enum.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
include_tracer.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
ipc_messages_log.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
make_gtest_filter_test.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
make_gtest_filter.py
autotest: Create correct test filters when a --line is specified
2022-10-12 13:47:30 +00:00
multi_process_rss.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
nocompile_driver.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
omahaproxy.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
OWNERS
Move license tooling into //tools/licenses
2022-11-11 16:38:42 +00:00
perry.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
PRESUBMIT.py
licenses.py SPDX format output
2022-11-10 19:01:24 +00:00
remove_duplicate_includes.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
remove_stale_pyc_files.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
roll_webgl_conformance.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
run-swarmed.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
sort_sources.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
uberblame.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
unused-symbols-report.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
update_pgo_profiles.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00
yes_no.py
Update copyright headers in testing/, tools/
2022-09-15 20:11:09 +00:00