0
Files
src/tools/code_cache_generator
Junji Watanabe e4090761fe Reland "build: Remove blocking deps from code_cache_generator link target"
This reverts commit 982ba5f1d2.

Reason for revert: This reland fixes the dependency name for snapshot_blob.bin.

Original change's description:
> Revert "build: Remove blocking deps from code_cache_generator link target"
>
> This reverts commit 2f5c5cc0a7.
>
> Reason for revert: It breaks https://ci.chromium.org/ui/p/chromium/builders/ci/linux-cast-x64-rel/13255/overview
>
> Original change's description:
> > build: Remove blocking deps from code_cache_generator link target
> >
> > Currently, `v8_context_snapshot_generator` link step and `code_cache_generator` link step run serially.
> > `code_cache_generator` was introduced in https://crrev.com/c/6096433,
> > which seems to cause the CQ build time regression crbug.com/396004680 observed by the infra team.
> >
> > This CL tries to make the v8_context_snapshot dep non-blocking.
> > See the build trace with this CL: http://screen/BJS56maU3oVcLJR
> >
> > Bug: 409228064, 396004680
> > Change-Id: Idfd21861dc21cee1281606f9517da2a5021c2cfe
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6440681
> > Auto-Submit: Junji Watanabe <jwata@google.com>
> > Commit-Queue: Junji Watanabe <jwata@google.com>
> > Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1445672}
>
> Bug: 409228064, 396004680
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I2bb743580bacbbf6dcb9f84202855e32f860f4e0
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6449230
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Keishi Hattori <keishi@chromium.org>
> Commit-Queue: Keishi Hattori <keishi@chromium.org>
> Auto-Submit: Junji Watanabe <jwata@google.com>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1445676}

Cq-Include-Trybots: luci.chromium.try:linux-cast-x64-rel
Bug: 409228064, 396004680
Change-Id: If5c6826bf018c8388bb170b19faed23fff203282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6450297
Commit-Queue: Junji Watanabe <jwata@google.com>
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tom Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1446361}
2025-04-13 19:08:20 -07:00
..