57c0d866fc
There is a bug in macOS where the usage of NSMenu.minimumWidth
causes menu items to be prematurely truncated. Given that
this is on Stable, do a clean revert.
Disabling the style warning because this is a revert. The
cleanup code will be re-landed later.
This reverts commit 1786625b69.
DISABLE_OBJECTIVE_C_STYLE
Bug: 389067059
Bug: 401443090
Change-Id: I1e06296f7647010a3ca36395b2a42953ec448203
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6347626
Commit-Queue: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Keren Zhu <kerenzhu@chromium.org>
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Auto-Submit: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1431666}
//ui/base
This directory contains low-level code that is reused throughout the chromium UI stack. Code in this directory can't depend on most of the rest of //ui (with a few exceptions), and code throughout the rest of //ui can depend on it.
Toolkit-specific libraries in this directory include:
- cocoa: for working with Cocoa on macOS
- wayland: for Linux systems with Wayland
- webui: for WebUI in Chromium
- win: for Windows systems
- (x): for Linux systems with X11
Platform-independent libraries in this directory include:
- l10n: localization APIs used throughout all of chromium, especially
the widely-used
l10n_util::GetString*functions - metadata: the implementation of the property/metadata system used throughout views
- models: toolkit-agnostic types used to represent the data shown in UI controls and dialogs
- resource: resource bundle APIs, which are used for retrieving icons and raw localized strings from the app package
As with most "base" libraries this is somewhat of a dumping ground of code that is used in a bunch of other places, and there's no hard and fast rule to tell what should or shouldn't be in here. If in doubt, consult with the owners.