eeae88c084
This reverts commit 76462a6abb.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5369201939185664
Sample build with failed test: https://ci.chromium.org/b/8726816977473469937
Affected test(s):
[ninja://ash:ash_unittests/HelpBubbleViewAshBodyIconTest.BodyIcon/All.0](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FHelpBubbleViewAshBodyIconTest.BodyIcon%2FAll.0?q=VHash%3A09a1217d4f1b1e5e)
[ninja://ash:ash_unittests/HelpBubbleViewAshBodyIconTest.BodyIcon/All.12](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FHelpBubbleViewAshBodyIconTest.BodyIcon%2FAll.12?q=VHash%3A09a1217d4f1b1e5e)
[ninja://ash:ash_unittests/HelpBubbleViewAshBodyIconTest.BodyIcon/All.3](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FHelpBubbleViewAshBodyIconTest.BodyIcon%2FAll.3?q=VHash%3A09a1217d4f1b1e5e)
[ninja://ash:ash_unittests/HelpBubbleViewAshBodyIconTest.BodyIcon/All.4](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FHelpBubbleViewAshBodyIconTest.BodyIcon%2FAll.4?q=VHash%3A09a1217d4f1b1e5e)
[ninja://ash:ash_unittests/HelpBubbleViewAshBodyIconTest.BodyIcon/All.8](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fash:ash_unittests%2FHelpBubbleViewAshBodyIconTest.BodyIcon%2FAll.8?q=VHash%3A09a1217d4f1b1e5e)
and 5 more ...
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5369201939185664&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6133053&type=BUG
Original change's description:
> Prevent default construction of VectorIcon.
>
> This avoids obscure bugs when VectorIcons are stored or compared based
> on address and the default (empty) icon is involved. Instead add a
> getter that returns a ref to a singleton empty icon.
>
> This obviates the need for kNoneIcon, which can't be made to work with
> these changes (easily, anyway), so that's replaced also.
>
> Bug: 364987728
> Low-Coverage-Reason: LARGE_SCALE_CHANGE no functional effect
> Change-Id: Ia93324b46e7fd1e28f4f1ad28168ecae915f9151
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6133053
> Reviewed-by: Evan Stade <estade@chromium.org>
> Owners-Override: David Yeung <dayeung@google.com>
> Commit-Queue: Peter Kasting <pkasting@chromium.org>
> Reviewed-by: David Yeung <dayeung@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1401567}
>
Bug: 364987728
Change-Id: I8911568818d8a556693343bc41eca0f09832f09f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6139406
Reviewed-by: Tim Sergeant <tsergeant@chromium.org>
Commit-Queue: Tim Sergeant <tsergeant@chromium.org>
Owners-Override: Tim Sergeant <tsergeant@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1401677}