0
Files
src/native_client_sdk/PRESUBMIT.py
Edward Lemur 11581e77e6 native_client_sdk: Remove GetPreferredTryMasters from PRESUBMIT.
The masters and bots listed don't exists anymore.
GetPreferredTryMasters is used by git-cl try to pick what bots
to trigger. I want to remove support for it, since its not used
and increases maintenance costs.
Skipping presubmit because of unrelated pylint failures.

No-Presubmit: true
Change-Id: I3f539a2d08444fc1dd3851777aeb1b9a71407bd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2072643
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Sam Clegg <sbc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#745327}
2020-02-28 02:18:32 +00:00

40 lines
1.3 KiB
Python

# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Top-level presubmit script for native_client_sdk.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
for more details on the presubmit API built into depot_tools.
"""
def CommonChecks(input_api, output_api):
output = []
disabled_warnings = [
'F0401', # Unable to import module
'R0401', # Cyclic import
'W0613', # Unused argument
'W0403', # relative import warnings
'E1103', # subprocess.communicate() generates these :(
'R0201', # method could be function (doesn't reference self)
]
black_list = [
r'src[\\\/]build_tools[\\\/]tests[\\\/].*',
r'src[\\\/]build_tools[\\\/]sdk_tools[\\\/]third_party[\\\/].*',
r'src[\\\/]doc[\\\/]*',
r'src[\\\/]gonacl_appengine[\\\/]*',
]
canned = input_api.canned_checks
output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,
disabled_warnings=disabled_warnings))
return output
def CheckChangeOnUpload(input_api, output_api):
return CommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return CommonChecks(input_api, output_api)