0
Files
src/testing
Mustafa Emre Acer 6023d60f71 [Reland] Don't attempt to upgrade zero-suggest autocomplete inputs to HTTPS
This CL fixes an issue with the Defaulting Typed Navigations to HTTPS
feature. Consider the following scenario:

1. User types https://example.com
2. Navigation completes successfully
3. User clicks the omnibox and hits enter
4. Omnibox attempts to upgrade this navigation to HTTPS.

In step 3, OmniboxEditModel::StartZeroSuggestRequest() creates an
AutocompleteInput using its client's
ShouldDefaultTypedNavigationsToHttps() value and "example.com" as the
input text. This causes AutocompleteInput to enable the HTTP fallback
logic if the HTTPS navigation times out, thus potentially downgrading
the connection.

This CL fixes this by disabling HTTPS upgrades when starting a zero
suggest request.

Bug: 1251065
Change-Id: I70a00f00bd646058fd62d31e4da572971bde0dbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3188350
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/main@{#926926}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3203050
Cr-Original-Commit-Position: refs/heads/main@{#928315}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3370903
Cr-Commit-Position: refs/heads/main@{#956558}
2022-01-07 17:28:18 +00:00
..