This patch removes a runtime enabled feature OutOfBlinkCors as
the feature was fully launched and the runtime flag should be
always enabled in Blink.
This patch contains only trivial changes, and will leave
TODOs for additional works to remove some more functions.
As blink unit tests run without the runtime flag enabled,
following tests do not work with OOR-CORS and do not make
much sense any more. They are removed in this patch too.
- ThreadableLoaderTest::DidFailRedirectCheck
- ThreadableLoaderTest::CancelInDidFailRedirectCheck
- ThreadableLoaderTest::ClearInDidFailRedirectCheck
Redirect limits are not handled in the ThreadableLoader any more.
Redirect-loop emulated at the mock layer does not make sense,
and does not generate any error and these tests just hang-up.
This is part of the work to remove the kOutOfBlinkCors feature.
- WebAssociatedURLLoaderTest::CrossOriginWithAccessControlSuccess
- WebAssociatedURLLoaderTest::CrossOriginWithAccessControlFailure
- WebAssociatedURLLoaderTest::RedirectCrossOriginWithAccessControlFailure
These tests verify very basic CORS functionalities for BlinkCORS.
As ThreadableLoader does not handle CORS checks any more, these
unit tests are not a right place to ensure that. We already have
similar tests for CorsURLLoader in the network service, and wpt
provides enough integration tests.
- ResourceLoaderTest::ResponseType
This test verifies if ResourceLoader can calculate response
tainting for BlinkCORS. As CORS checks are disabled in
ResourceLoader and we just use the type provided via network
service, we don't need this test.
Bug: 1053866, 1003943
Change-Id: I656a86a42873ddbeafeae70d611b3072b6926c01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379336
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#803436}
70bddadf50