0
Files
src/ios
Chris Lu 40b6cd645a [ios] Set ClearBrowsingDataTableViewController and its NavigationController to nil immediately after completing dismiss
When a URL is opened, CBD dismisses itself. Then History checks with the CBD coordinator to make sure that CBD is dismissed (nav controller is nil) before dismissing itself. Since we don't set the navController to nil before calling the completion block in dismissClearBrowsingDataWithCompletion:, the CBD coordinator thinks that it still exists so it attempts `[self dismissClearBrowsingDataWithCompletion:completionHandler];`, which then doesn't execute the completion block since there was nothing to dismiss.

Video: https://drive.google.com/open?id=1A7-W5LXhjzvh4DcUQguQEv0qWC88Ncp1

Bug: 877243

Change-Id: Id2f67c934e0ef2033abc28f97bb9bf211dbb5ddb
Reviewed-on: https://chromium-review.googlesource.com/1187631
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585857}
2018-08-24 15:55:38 +00:00
..
2018-08-22 09:46:15 +00:00
2018-08-22 18:17:04 +00:00

This directory holds code related to the iOS port of Chromium. See
https://sites.google.com/a/chromium.org/dev/developers/design-documents/structure-of-layered-components-within-the-chromium-codebase
for a description of the structure underneath this directory.