
Currently, the InsetObserver is managed by the WindowAndroid, which is only created by certain activities. With edge-to-edge everywhere, all activities will need access to the InsetObserver to properly observe the window insets, so this change passes the InsetObserver to ChromeBaseAppCompatActivity. The InsetObserver should be passed to any WindowAndroid that needs access to it through the WindowAndroid constructor. Bug: 374641218 Change-Id: Id42a26f7c9848b50fc5fde49074583719e645413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5945405 Reviewed-by: Tomasz Wiszkowski <ender@google.com> Reviewed-by: Vigen Issahhanjan <vigeni@google.com> Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Charles Hager <clhager@google.com> Reviewed-by: Theresa Sullivan <twellington@chromium.org> Reviewed-by: Richard (Torne) Coles <torne@chromium.org> Reviewed-by: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by: Wenyu Fu <wenyufu@chromium.org> Reviewed-by: Antonio Rivera <antoniori@google.com> Cr-Commit-Position: refs/heads/main@{#1373467}
Cast base
cast_features
This file contains tools for checking the feature state of all of the features which affect Cast products. Cast features build upon the Chrome feature system. Some aspects of Cast require the feature system to work differently, however, so some additional logic has been layered on top. Details are available in comments of the header file. The basics are:
- If you are adding a new feature, add it to
cast_features.cc
so it lives alongside existing features - Add your new feature to the list of
kFeatures
incast_features.cc
BASE_FEATURE(kMyFeature, "my_feature", base::FEATURE_DISABLED_BY_DEFAULT);
const base::Feature* kFeatures[] = {
// ..other features
&kMyFeature
}