There were several places that registered observers for child views but
never unregistered. Such observers do not behave quite as expected at
destruction time, since observer methods are virtual, and the child
views are not destroyed until the View base class is destroyed. In
practice, this is mostly benign, but per the C++ standard, this is
undefined behavior and MSan's use-after-dtor error is capable of
catching such mistakes.
Bug: 40222690
Change-Id: I88b0276c6ea0d4c12d070e7ab13496736fe6fe6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5646994
Reviewed-by: Yuki Awano <yawano@google.com>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1320122}
f5ad04b684