0
Files
src/native_client_sdk/PRESUBMIT.py
sbc@chromium.org fe381f5b79 [NaCL SDK] Roll naclports revision.
Roll naclports 850 -> 954.  This fixes the accidental
include of the supplemental newlib headers in the ports
bundle.

Most of the changes in the range we are pulling in are
unrelated to the ports that we ship.  A lot of them are
build script related and adding of new ports.  The revisions
of interest are:

 949 - Add port of lua 5.2 and use it in lua_ppapi example.
 948 - Fix accidental modification of top level sdklibs target.

The former changes the default lua version from 5.1 to 5.2
which means we will now be shipping liblua 5.2 in the SDK.
The latter removes the accidentally included headers which
actually fixes bug 313403.

R=binji@chromium.org, binji
BUG=313403

Review URL: https://codereview.chromium.org/52713007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232167 0039d316-1c4b-4281-b951-d872f2087c98
2013-10-31 18:11:52 +00:00

50 lines
1.4 KiB
Python

# Copyright (c) 2012 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
"""Top-level presubmit script for isolate.
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for
details on the presubmit API built into gcl.
"""
def CommonChecks(input_api, output_api):
output = []
disabled_warnings = [
'F0401', # Unable to import module
'R0401', # Cyclic import
'W0613', # Unused argument
'E1103', # subprocess.communicate() generates these :(
'R0201', # method could be function (doesn't reference self)
]
black_list = [
r'src[\\\/]build_tools[\\\/]tests[\\\/].*',
r'src[\\\/]build_tools[\\\/]sdk_tools[\\\/]third_party[\\\/].*',
r'src[\\\/]doc[\\\/]*',
r'src[\\\/]gonacl_appengine[\\\/]*',
]
canned = input_api.canned_checks
output.extend(canned.RunPylint(input_api, output_api, black_list=black_list,
disabled_warnings=disabled_warnings))
return output
def CheckChangeOnUpload(input_api, output_api):
return CommonChecks(input_api, output_api)
def CheckChangeOnCommit(input_api, output_api):
return CommonChecks(input_api, output_api)
def GetPreferredTrySlaves(project, change):
return [
'linux_nacl_sdk',
'linux_nacl_sdk_build',
'win_nacl_sdk',
'win_nacl_sdk_build',
'mac_nacl_sdk',
'mac_nacl_sdk_build'
]