chromium/src
0
Fork 0
Code Activity
Files
77b7586cdd8e4a6d18263dc53183e8be422ac1d0
src/content/renderer
History
Thomas Lukaszewicz bbd83a20cf [discard] Ensure FrameTree::Discard clears service workers 
This CL ensures that any service workers registered against a
discarded RenderFrameHostImpl are cleared following the a
discard operation.

Previously service workers were not being cleared as expected
because the commit params used to commit the new empty document
for discard copied over the service worker network provider
in DocumentLoader::CreateWebNavigationParamsToCloneDocument() [1].

As a result service workers could persist for the discarded frame
in the case the associated process was not proactively shut down.

This CL addresses this by clearing the ServiceWorkerNetworkProvider
when a discarded document is installed. This breaks the container
host pipe with the browser and the ServiceWorkerClient is
destroyed [2].

The ServiceWorkerNetworkProviderForFrame class lives in //content/
and must be replaced with
ServiceWorkerNetworkProviderForFrame::CreateInvalidInstance()
instead of being nullified in blink as the network provider is
expected to be not-null, see [3].

[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/loader/document_loader.cc;l=743;drc=492dc9719f6e1845f4f5c0553cd5c7651115f671

[2] https://source.chromium.org/chromium/chromium/src/+/main:content/browser/service_worker/service_worker_context_core.cc;l=527;drc=492dc9719f6e1845f4f5c0553cd5c7651115f671

[3] https://source.chromium.org/chromium/chromium/src/+/main:content/renderer/render_frame_impl.cc;l=3045;drc=4c6d5b3c3ed16fa75258c6b4763188f840cb433d

Bug: 404877558
Change-Id: If0d495b94d4b5be38f2832152437a4b460f63692
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6367564
Reviewed-by: Rakina Zata Amni <rakina@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Tom Lukaszewicz <tluk@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1436434}
2025-03-22 00:16:54 -07:00
..
accessibility
Add main content extractor client type.
2025-03-19 22:36:43 -07:00
font_data
Create base::HashCombine.
2025-03-21 07:38:19 -07:00
java
Migrate to NOTREACHED() in content/
2024-10-31 19:37:21 +00:00
media
Remove stable video decoding Mojo interfaces
2025-03-17 13:07:19 -07:00
mojo
…
pepper
[//cc] Rename TextureLayer::CreateForMailbox() to Create()
2025-03-21 10:42:57 -07:00
service_worker
[discard] Ensure FrameTree::Discard clears service workers
2025-03-22 00:16:54 -07:00
worker
Remove WebVector: Manual changes before automatic changes
2025-01-28 15:24:17 -08:00
agent_scheduling_group.cc
Don't set opener of placeholder RemoteFrame.
2024-11-20 18:17:48 +00:00
agent_scheduling_group.h
Rewrite map pointer values to raw_ptr
2024-09-30 17:58:53 +00:00
background_resource_fetch_assets.cc
…
background_resource_fetch_assets.h
…
blink_platform_audio_hardware_browsertest.cc
…
browser_exposed_renderer_interfaces.cc
…
browser_exposed_renderer_interfaces.h
…
browser_render_view_browsertest.cc
[BRP] Rewrite a couple pointers to raw_ptr<> in content/renderer/*_browsertest.cc
2024-07-01 02:59:18 +00:00
BUILD.gn
[DevTools] Defer client-initiated navigations while CDP command dispatch is pending
2025-02-24 22:28:18 -08:00
client_navigation_throttler_unittest.cc
[DevTools] Defer client-initiated navigations while CDP command dispatch is pending
2025-02-24 22:28:18 -08:00
client_navigation_throttler.cc
[DevTools] Defer client-initiated navigations while CDP command dispatch is pending
2025-02-24 22:28:18 -08:00
client_navigation_throttler.h
[DevTools] Defer client-initiated navigations while CDP command dispatch is pending
2025-02-24 22:28:18 -08:00
content_security_policy_util_fuzzer.cc
Prepare to remove //content/ from unsafe_bufers_paths.txt
2024-06-08 05:13:06 +00:00
content_security_policy_util_unittest.cc
require-sri-for: 'script'
2025-02-13 07:10:09 -08:00
content_security_policy_util.cc
require-sri-for: 'script'
2025-02-13 07:10:09 -08:00
content_security_policy_util.h
Remove WebVector: Automatic changes
2025-01-28 17:57:12 -08:00
DEPS
content: Add URLLoaderFactory able to serve resources in-process
2025-01-13 16:28:51 -08:00
discardable_memory_utils.cc
…
discardable_memory_utils.h
…
document_state.cc
[discard] Address same-document navigation crash during discard
2024-08-28 21:34:50 +00:00
document_state.h
[discard] Address same-document navigation crash during discard
2024-08-28 21:34:50 +00:00
dom_automation_controller.cc
Migrate to NOTREACHED() in content/
2024-10-31 19:37:21 +00:00
dom_automation_controller.h
…
dom_serializer_browsertest.cc
Remove WebVector: Automatic changes
2025-01-28 17:57:12 -08:00
effective_connection_type_helper.cc
…
effective_connection_type_helper.h
…
frame_owner_properties_converter.cc
…
frame_owner_properties_converter.h
…
gin_browsertest.cc
…
gpu_benchmarking_extension.cc
[rust png] Use SkPngRustEncoder (if enabled) when encoding SkImages.
2024-12-18 08:15:18 -08:00
gpu_benchmarking_extension.h
…
in_process_renderer_thread.cc
…
in_process_renderer_thread.h
…
local_resource_url_loader_factory_unittest.cc
Eliminate copy of config in LocalResourceURLLoaderFactory ctor
2025-01-23 13:14:50 -08:00
local_resource_url_loader_factory.cc
Remove const from key type in TemplateExpressions lib
2025-02-03 14:30:23 -08:00
local_resource_url_loader_factory.h
Remove const from key type in TemplateExpressions lib
2025-02-03 14:30:23 -08:00
mhtml_handle_writer.cc
Remove file-wide unsafe buffer suppression from content/ [7 of N]
2025-03-13 11:16:28 -07:00
mhtml_handle_writer.h
…
mock_agent_scheduling_group.cc
Remove unused, unsafe AgentGroupSchedulerImpl::broker_ field.
2024-06-26 15:29:53 +00:00
mock_agent_scheduling_group.h
…
navigation_client.cc
Move PermissionsPolicy to the network service
2025-02-28 09:24:35 -08:00
navigation_client.h
Move PermissionsPolicy to the network service
2025-02-28 09:24:35 -08:00
navigation_state.cc
Add CommitReceived milestone to AbandonedPLMO
2024-07-24 17:59:14 +00:00
navigation_state.h
Add CommitReceived milestone to AbandonedPLMO
2024-07-24 17:59:14 +00:00
net_info_helper.cc
Migrate to NOTREACHED() in content/
2024-10-31 19:37:21 +00:00
net_info_helper.h
…
OWNERS
Remove danakj from OWNERS files
2024-11-08 21:56:14 +00:00
policy_container_util.cc
CrossOriginIsolation enabled by DIP bypasses COI permission
2025-02-05 08:02:20 -08:00
policy_container_util.h
…
PRESUBMIT_test.py
…
PRESUBMIT.py
…
render_frame_impl_browsertest.cc
Rename visible_viewport_rect to visible_viewport_rect_device_px
2025-02-13 17:05:47 -08:00
render_frame_impl.cc
Combine Frame IPC's CreateNewWindow and ShowCreatedWindow
2025-03-19 15:03:45 -07:00
render_frame_impl.h
Combine Frame IPC's CreateNewWindow and ShowCreatedWindow
2025-03-19 15:03:45 -07:00
render_process_impl.cc
[v8][wasm] Remove WebAssemblyMemory64 flag
2025-02-11 01:47:27 -08:00
render_process_impl.h
…
render_process.cc
[task] Merge kCompositing into kDisplayCritical
2024-08-21 16:42:37 +00:00
render_process.h
…
render_thread_impl_browsertest.cc
Fix and re-enable TransferSharedLastForegroundTime test
2024-10-23 16:24:14 +00:00
render_thread_impl_discardable_memory_browsertest.cc
Disable flaky RenderThreadImplDiscardableMemoryBrowserTest
2025-01-15 01:05:33 -08:00
render_thread_impl_unittest.cc
…
render_thread_impl.cc
[tracing] Make TraceableState work in the field
2025-03-20 13:30:43 -07:00
render_thread_impl.h
[tracing] Make TraceableState work in the field
2025-03-20 13:30:43 -07:00
render_view_browsertest_mac.mm
Replace CHECK(false) in content/
2024-11-20 15:49:39 +00:00
render_view_browsertest.cc
Combine Frame IPC's CreateNewWindow and ShowCreatedWindow
2025-03-19 15:03:45 -07:00
render_widget_browsertest.cc
Remove CursorAnchorInfoMojoPipe flag as it's enabled by default
2025-02-28 05:55:58 -08:00
renderer_blink_platform_impl.cc
Remove file-wide unsafe buffer suppression from content/ [7 of N]
2025-03-13 11:16:28 -07:00
renderer_blink_platform_impl.h
[webui] Propagate WebUI bundled code cache to renderers on process-lock
2025-03-12 18:53:36 -07:00
renderer_main_platform_delegate_android.cc
…
renderer_main_platform_delegate_fuchsia.cc
…
renderer_main_platform_delegate_ios.mm
…
renderer_main_platform_delegate_linux.cc
…
renderer_main_platform_delegate_mac.mm
…
renderer_main_platform_delegate_win.cc
Add a feature flag to run FontDataManager on all pages
2025-02-11 13:22:25 -08:00
renderer_main_platform_delegate.h
…
renderer_main.cc
Pre-create DirectReceiver transports on Windows
2025-03-19 11:14:08 -07:00
sad_plugin.cc
…
sad_plugin.h
…
sandbox_mac_v2_unittest.mm
Mac sandbox: don't use protobuf for policy serialization
2025-01-31 16:09:37 -08:00
savable_resources_browsertest.cc
Disable flaky test on windows
2025-01-17 08:42:43 -08:00
seccomp_sandbox_status_android.cc
…
seccomp_sandbox_status_android.h
…
skia_benchmarking_extension_unittest.cc
…
skia_benchmarking_extension.cc
Remove uses of symbols in SkColorPriv.h
2025-03-07 04:19:36 -08:00
skia_benchmarking_extension.h
…
stats_collection_controller.cc
…
stats_collection_controller.h
…
stream_texture_host_android.cc
…
stream_texture_host_android.h
…
theme_helper_mac.h
Remove unused code remnants
2024-09-11 15:27:54 +00:00
theme_helper_mac.mm
Remove unused code remnants
2024-09-11 15:27:54 +00:00
v8_value_converter_impl_unittest.cc
Suppress unsafe_libc_call warning for initial identified files.
2025-01-28 18:11:08 -08:00
v8_value_converter_impl.cc
Migrate absl variant.h and utility.h in content (part 2/2)
2025-03-18 12:51:48 -07:00
v8_value_converter_impl.h
…
variations_render_thread_observer.cc
[Code Health] Remove omnibox http header feature
2024-12-05 16:23:18 +00:00
variations_render_thread_observer.h
…
visual_state_browsertest.cc
…
web_ui_extension_data.cc
Move blink/public/common/browser_interface_broker_proxy.h to platform/
2024-07-14 20:25:02 +00:00
web_ui_extension_data.h
…
web_ui_extension.cc
Migrate to NOTREACHED() in content/
2024-10-31 19:37:21 +00:00
web_ui_extension.h
…
webclipboard_impl_browsertest.cc
…
webgraphicscontext3d_provider_impl.cc
Use moved Skia Ganesh headers
2024-09-04 01:32:55 +00:00
webgraphicscontext3d_provider_impl.h
…