0189cf30e3
- Conditionally include browser_message_filter.h/cc in the build - Remove unused imports of browser_message_filter.h - Remove unused chrome::bad_message::ReceivedBadMessage - Remove unused BrowserAssociatedInterface Bug: 993189 Change-Id: Icf114631fbc495b660aafe1a148e716cc7a19f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5177633 Reviewed-by: David Bertoni <dbertoni@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Bo Liu <boliu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/main@{#1244658}
85 lines
2.9 KiB
C++
85 lines
2.9 KiB
C++
// Copyright 2015 The Chromium Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "content/browser/bad_message.h"
|
|
|
|
#include "base/debug/dump_without_crashing.h"
|
|
#include "base/functional/bind.h"
|
|
#include "base/logging.h"
|
|
#include "base/metrics/histogram_functions.h"
|
|
#include "base/strings/string_number_conversions.h"
|
|
#include "base/trace_event/trace_event.h"
|
|
#include "content/public/browser/browser_message_filter.h"
|
|
#include "content/public/browser/browser_task_traits.h"
|
|
#include "content/public/browser/browser_thread.h"
|
|
#include "content/public/browser/render_process_host.h"
|
|
|
|
namespace content {
|
|
namespace bad_message {
|
|
|
|
namespace {
|
|
|
|
void LogBadMessage(BadMessageReason reason) {
|
|
static auto* const bad_message_reason = base::debug::AllocateCrashKeyString(
|
|
"bad_message_reason", base::debug::CrashKeySize::Size64);
|
|
|
|
TRACE_EVENT_INSTANT1("ipc,security", "content::ReceivedBadMessage",
|
|
TRACE_EVENT_SCOPE_THREAD, "reason", reason);
|
|
LOG(ERROR) << "Terminating renderer for bad IPC message, reason " << reason;
|
|
base::UmaHistogramSparse("Stability.BadMessageTerminated.Content", reason);
|
|
base::debug::SetCrashKeyString(bad_message_reason,
|
|
base::NumberToString(reason));
|
|
}
|
|
|
|
void ReceivedBadMessageOnUIThread(int render_process_id,
|
|
BadMessageReason reason) {
|
|
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
|
|
RenderProcessHost* host = RenderProcessHost::FromID(render_process_id);
|
|
if (!host)
|
|
return;
|
|
|
|
// A dump has already been generated by the caller. Don't generate another.
|
|
host->ShutdownForBadMessage(
|
|
RenderProcessHost::CrashReportMode::NO_CRASH_DUMP);
|
|
}
|
|
|
|
} // namespace
|
|
|
|
void ReceivedBadMessage(RenderProcessHost* host, BadMessageReason reason) {
|
|
LogBadMessage(reason);
|
|
host->ShutdownForBadMessage(
|
|
RenderProcessHost::CrashReportMode::GENERATE_CRASH_DUMP);
|
|
}
|
|
|
|
void ReceivedBadMessage(int render_process_id, BadMessageReason reason) {
|
|
// We generate a crash dump here since generating one after posting to the UI
|
|
// thread is less useful.
|
|
LogBadMessage(reason);
|
|
base::debug::DumpWithoutCrashing();
|
|
|
|
if (!BrowserThread::CurrentlyOn(BrowserThread::UI)) {
|
|
GetUIThreadTaskRunner({})->PostTask(
|
|
FROM_HERE, base::BindOnce(&ReceivedBadMessageOnUIThread,
|
|
render_process_id, reason));
|
|
return;
|
|
}
|
|
ReceivedBadMessageOnUIThread(render_process_id, reason);
|
|
}
|
|
|
|
#if BUILDFLAG(CONTENT_ENABLE_LEGACY_IPC)
|
|
void ReceivedBadMessage(BrowserMessageFilter* filter, BadMessageReason reason) {
|
|
LogBadMessage(reason);
|
|
filter->ShutdownForBadMessage();
|
|
}
|
|
#endif
|
|
|
|
base::debug::CrashKeyString* GetRequestedSiteInfoKey() {
|
|
static auto* const crash_key = base::debug::AllocateCrashKeyString(
|
|
"requested_site_info", base::debug::CrashKeySize::Size256);
|
|
return crash_key;
|
|
}
|
|
|
|
} // namespace bad_message
|
|
} // namespace content
|