d0bb793c40
This patch should effectively be a no-op, replacing one flag `ExperimentalRenderer` by another `DanglingUntriaged`. Both currently share the same value, but a different meaning. Kalvin applied the MiraclePtr rewrite in the renderer process: https://chromium-review.googlesource.com/c/chromium/src/+/4904523 We still need to opt-in checking them with the DanglingPointerDetector. This applies pass 1 of the DanglingPointerDetector annotation process: https://docs.google.com/document/d/1GmGagDZtxHpWXJDKqlmzSaqaO5D-pavfH5IRGITfANs/edit#heading=h.s23pazuno76f 1. Rebase and apply the instrumentation CL 2. Compile the compiler: ./tools/clang/scripts/build.py --without-fuchsia 3. Run all the gtests. You can use this script. 4. Concatenate all the output_*, `filter`, `sort -nr`, `uniq`. 5. Install and run https://github.com/ArthurSonzogni/chrome-dangling-ptr-apply-edit 6. Run git cl format 7. Run git checkout origin/main -- base/allocator/partition_allocator/pointers/raw_ptr_unittest.cc AX-Relnotes: n/a. Bug: 144624 Change-Id: Ib5b085c05cb5298ce7b7e3be3b474e9d4092b9ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4905816 Reviewed-by: Bartek Nowierski <bartekn@chromium.org> Owners-Override: danakj <danakj@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/main@{#1204624}
98 lines
3.7 KiB
C++
98 lines
3.7 KiB
C++
// Copyright 2012 The Chromium Authors
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#ifndef CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
|
|
#define CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
|
|
|
|
#include <map>
|
|
|
|
#include "base/memory/raw_ptr.h"
|
|
#include "base/values.h"
|
|
#include "content/common/content_export.h"
|
|
#include "content/public/renderer/v8_value_converter.h"
|
|
|
|
namespace content {
|
|
|
|
class CONTENT_EXPORT V8ValueConverterImpl : public V8ValueConverter {
|
|
public:
|
|
V8ValueConverterImpl();
|
|
|
|
V8ValueConverterImpl(const V8ValueConverterImpl&) = delete;
|
|
V8ValueConverterImpl& operator=(const V8ValueConverterImpl&) = delete;
|
|
|
|
// V8ValueConverter implementation.
|
|
void SetDateAllowed(bool val) override;
|
|
void SetRegExpAllowed(bool val) override;
|
|
void SetFunctionAllowed(bool val) override;
|
|
void SetStripNullFromObjects(bool val) override;
|
|
void SetConvertNegativeZeroToInt(bool val) override;
|
|
void SetStrategy(Strategy* strategy) override;
|
|
v8::Local<v8::Value> ToV8Value(base::ValueView value,
|
|
v8::Local<v8::Context> context) override;
|
|
std::unique_ptr<base::Value> FromV8Value(
|
|
v8::Local<v8::Value> value,
|
|
v8::Local<v8::Context> context) override;
|
|
|
|
private:
|
|
friend class ScopedAvoidIdentityHashForTesting;
|
|
|
|
class FromV8ValueState;
|
|
class ScopedUniquenessGuard;
|
|
|
|
v8::Local<v8::Value> ToV8ValueImpl(v8::Isolate* isolate,
|
|
v8::Local<v8::Object> creation_context,
|
|
base::ValueView value) const;
|
|
v8::Local<v8::Value> ToV8Array(v8::Isolate* isolate,
|
|
v8::Local<v8::Object> creation_context,
|
|
const base::Value::List& list) const;
|
|
v8::Local<v8::Value> ToV8Object(v8::Isolate* isolate,
|
|
v8::Local<v8::Object> creation_context,
|
|
const base::Value::Dict& dictionary) const;
|
|
v8::Local<v8::Value> ToArrayBuffer(
|
|
v8::Isolate* isolate,
|
|
v8::Local<v8::Object> creation_context,
|
|
const base::Value::BlobStorage& value) const;
|
|
|
|
std::unique_ptr<base::Value> FromV8ValueImpl(FromV8ValueState* state,
|
|
v8::Local<v8::Value> value,
|
|
v8::Isolate* isolate) const;
|
|
std::unique_ptr<base::Value> FromV8Array(v8::Local<v8::Array> array,
|
|
FromV8ValueState* state,
|
|
v8::Isolate* isolate) const;
|
|
|
|
// This will convert objects of type ArrayBuffer or any of the
|
|
// ArrayBufferView subclasses.
|
|
std::unique_ptr<base::Value> FromV8ArrayBuffer(v8::Local<v8::Object> val,
|
|
v8::Isolate* isolate) const;
|
|
|
|
std::unique_ptr<base::Value> FromV8Object(v8::Local<v8::Object> object,
|
|
FromV8ValueState* state,
|
|
v8::Isolate* isolate) const;
|
|
|
|
// If true, we will convert Date JavaScript objects to doubles.
|
|
bool date_allowed_;
|
|
|
|
// If true, we will convert RegExp JavaScript objects to string.
|
|
bool reg_exp_allowed_;
|
|
|
|
// If true, we will convert Function JavaScript objects to dictionaries.
|
|
bool function_allowed_;
|
|
|
|
// If true, undefined and null values are ignored when converting v8 objects
|
|
// into Values.
|
|
bool strip_null_from_objects_;
|
|
|
|
// If true, convert -0 to an integer value (instead of a double).
|
|
bool convert_negative_zero_to_int_;
|
|
|
|
bool avoid_identity_hash_for_testing_;
|
|
|
|
// Strategy object that changes the converter's behavior.
|
|
raw_ptr<Strategy, DanglingUntriaged> strategy_;
|
|
};
|
|
|
|
} // namespace content
|
|
|
|
#endif // CONTENT_RENDERER_V8_VALUE_CONVERTER_IMPL_H_
|