12e19bd089
This was redundant with `AccessPoint::` that always came before the
name of the enum entry.
This is part of the chain:
> crrev.com/c/6170210
> crrev.com/i/7949886 (which can be merged in parallel with the next one)
=> crrev.com/c/6168847 (which should be transformed into a LSC
once validated)
> crrev.com/c/6169909
This CL allows to remove 13 characters per line. Given that those
lines always contains the already long `signin_metrics::AccessPoints`,
I hope that, not only it will be slightly easier to read. But it would
ensure that some lines could be reformatted to be under the 80
character limit, thus avoiding warnings during upload.
There is no change in the java files using this enum, because the code
generation of java already removed this prefix.
This CL was obtained by the following python script.
```
import subprocess
"""Pairs of old name/new name"""
names= [ ("ACCESS_POINT_START_PAGE", "kStartPage"),
("ACCESS_POINT_NTP_LINK", "kNTPLink"),
("ACCESS_POINT_MENU", "kMenu"),
#sync off row must appear before kSettings
("ACCESS_POINT_SETTINGS_SYNC_OFF_ROW", "kSettingsSyncOffRow"),
("ACCESS_POINT_SETTINGS", "kSettings"),
("ACCESS_POINT_SUPERVISED_USER", "kSupervisedUser"),
("ACCESS_POINT_EXTENSION_INSTALL_BUBBLE", "kExtensionInstallBubble"),
("ACCESS_POINT_EXTENSIONS", "kExtensions"),
("ACCESS_POINT_BOOKMARK_BUBBLE", "kBookmarkBubble"),
("ACCESS_POINT_BOOKMARK_MANAGER", "kBookmarkManager"),
# WithSyncPromo must appear before the other kAvatarBubbleSignIn
("ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN_WITH_SYNC_PROMO",
"kAvatarBubbleSignInWithSyncPromo"),
("ACCESS_POINT_AVATAR_BUBBLE_SIGN_IN", "kAvatarBubbleSignIn"),
("ACCESS_POINT_USER_MANAGER", "kUserManager"),
("ACCESS_POINT_DEVICES_PAGE", "kDevicesPage"),
("ACCESS_POINT_SIGNIN_PROMO", "kSigninPromo"),
("ACCESS_POINT_RECENT_TABS", "kRecentTabs"),
("ACCESS_POINT_UNKNOWN", "kUnknown"),
("ACCESS_POINT_PASSWORD_BUBBLE", "kPasswordBubble"),
("ACCESS_POINT_AUTOFILL_DROPDOWN", "kAutofillDropdown"),
("ACCESS_POINT_RESIGNIN_INFOBAR", "kResigninInfobar"),
("ACCESS_POINT_TAB_SWITCHER", "kTabSwitcher"),
("ACCESS_POINT_MACHINE_LOGON", "kMachineLogon"),
("ACCESS_POINT_GOOGLE_SERVICES_SETTINGS", "kGoogleServicesSettings"),
("ACCESS_POINT_SYNC_ERROR_CARD", "kSyncErrorCard"),
("ACCESS_POINT_FORCED_SIGNIN", "kForcedSignin"),
("ACCESS_POINT_ACCOUNT_RENAMED", "kAccountRenamed"),
("ACCESS_POINT_WEB_SIGNIN", "kWebSignin"),
("ACCESS_POINT_SAFETY_CHECK", "kSafetyCheck"),
("ACCESS_POINT_KALEIDOSCOPE", "kKaleidoscope"),
("ACCESS_POINT_ENTERPRISE_SIGNOUT_COORDINATOR", "kEnterpriseSignoutCoordinator"),
("ACCESS_POINT_SIGNIN_INTERCEPT_FIRST_RUN_EXPERIENCE",
"kSigninInterceptFirstRunExperience"),
("ACCESS_POINT_SEND_TAB_TO_SELF_PROMO", "kSendTabToSelfPromo"),
("ACCESS_POINT_NTP_FEED_TOP_PROMO", "kNTPFeedTopPromo"),
("ACCESS_POINT_POST_DEVICE_RESTORE_SIGNIN_PROMO", "kPostDeviceRestoreSigninPromo"),
("ACCESS_POINT_POST_DEVICE_RESTORE_BACKGROUND_SIGNIN",
"kPostDeviceRestoreBackgroundSignin"),
("ACCESS_POINT_NTP_SIGNED_OUT_ICON", "kNTPSignedOutIcon"),
("ACCESS_POINT_NTP_FEED_CARD_MENU_PROMO", "kNTPFeedCardMenuPromo"),
("ACCESS_POINT_NTP_FEED_BOTTOM_PROMO", "kNTPFeedBottomPromo"),
("ACCESS_POINT_DESKTOP_SIGNIN_MANAGER", "kDesktopSigninManager"),
("ACCESS_POINT_FOR_YOU_FRE", "kForYouFRE"),
("ACCESS_POINT_CREATOR_FEED_FOLLOW", "kCreatorFeedFollow"),
("ACCESS_POINT_READING_LIST", "kReadingList"),
("ACCESS_POINT_REAUTH_INFO_BAR", "kReauthInfoBar"),
("ACCESS_POINT_ACCOUNT_CONSISTENCY_SERVICE", "kAccountConsistencyService"),
("ACCESS_POINT_SEARCH_COMPANION", "kSearchCompanion"),
("ACCESS_POINT_SET_UP_LIST", "kSetUpList"),
("ACCESS_POINT_PASSWORD_MIGRATION_WARNING_ANDROID",
"kPasswordMigrationWarningAndroid"),
("ACCESS_POINT_SAVE_TO_PHOTOS_IOS", "kSaveToPhotosIOS"),
("ACCESS_POINT_CHROME_SIGNIN_INTERCEPT_BUBBLE", "kChromeSigninInterceptBubble"),
("ACCESS_POINT_RESTORE_PRIMARY_ACCOUNT_ON_PROFILE_LOAD",
"kRestorePrimaryAccountOnProfileLoad"),
("ACCESS_POINT_TAB_ORGANIZATION", "kTabOrganization"),
("ACCESS_POINT_SAVE_TO_DRIVE_IOS", "kSaveToDriveIOS"),
("ACCESS_POINT_TIPS_NOTIFICATION", "kTipsNotification"),
("ACCESS_POINT_NOTIFICATIONS_OPT_IN_SCREEN_CONTENT_TOGGLE",
"kNotificationsOptInScreenContentToggle"),
("ACCESS_POINT_SIGNIN_CHOICE_REMEMBERED", "kSigninChoiceRemembered"),
("ACCESS_POINT_PROFILE_MENU_SIGNOUT_CONFIRMATION_PROMPT",
"kProfileMenuSignoutConfirmationPrompt"),
("ACCESS_POINT_SETTINGS_SIGNOUT_CONFIRMATION_PROMPT",
"kSettingsSignoutConfirmationPrompt"),
("ACCESS_POINT_NTP_IDENTITY_DISC", "kNTPIdentityDisc"),
("ACCESS_POINT_OIDC_REDIRECTION_INTERCEPTION", "kOIDCRedirectionInterception"),
("ACCESS_POINT_WEBAUTHN_MODAL_DIALOG", "kWebauthnModalDialog"),
#kAccountMenuFailedSwitch must occur before kAccountMenu
("ACCESS_POINT_ACCOUNT_MENU_FAILED_SWITCH", "kAccountMenuFailedSwitch"),
("ACCESS_POINT_ACCOUNT_MENU", "kAccountMenu"),
("ACCESS_POINT_PRODUCT_SPECIFICATIONS", "kProductSpecifications"),
("ACCESS_POINT_ADDRESS_BUBBLE", "kAddressBubble"),
("ACCESS_POINT_CCT_ACCOUNT_MISMATCH_NOTIFICATION",
"kCCTAccountMismatchNotification"),
("ACCESS_POINT_DRIVE_FILE_PICKER_IOS", "kDriveFilePickerIOS"),
("ACCESS_POINT_COLLABORATION_TAB_GROUP", "kCollaborationTabGroup")
]
for (old_name, new_name) in names:
print(f"Replacing {old_name} by {new_name}")
subprocess.run(f"""grep --exclude-dir="*.git" -rl "\\b{old_name}\\b" ios_internal ios components chrome |xargs sed -i "" "s/{old_name}/{new_name}/g" """, shell = True)
#Cancel change in the declaration. It’ll be done in a separate CL.
subprocess.run("""git restore -s HEAD components/signin/public/base/signin_metrics.h; git cl format""")
```
NO_IFTTT=This CL only change a value by a synonym, no metrics changed
Bug: 389192722
Change-Id: Ia2bf67d3cc611be44f3c40d6bbfe8d65af78bd9a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6168847
Owners-Override: Arthur Milchior <arthurmilchior@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Commit-Queue: Arthur Milchior <arthurmilchior@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1409093}
9 lines
260 B
Plaintext
9 lines
260 B
Plaintext
[Signin]Rename AccessPoint enum entries
|
|
|
|
See go/access_point_shorter to see how those patches were generated.
|
|
|
|
This allows to remove at least 13 characters per line and avoid the
|
|
redundant double "access point" when the entry is used.
|
|
|
|
R: droger
|
|
Bug: 389192722 |