
This reverts commit dc1fb3ffda
.
Reason for revert:
LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5091314988220416
Sample build with failed test: https://ci.chromium.org/b/8724836128577596785
Affected test(s):
[ninja://chrome/test:browser_tests/OpticalCharacterRecognizerTest.PerformOCR_PdfMetrics/All.OCR_Enabled_Library_Available](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Ftest:browser_tests%2FOpticalCharacterRecognizerTest.PerformOCR_PdfMetrics%2FAll.OCR_Enabled_Library_Available?q=VHash%3A15e8c90d55ca90bb)
If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5091314988220416&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5973241&type=BUG
Original change's description:
> Skip stale filehandle in proc_util.cc
>
> This fixes a crash in the sandbox when running tests in Cider.
>
> Also remove the is_cog() function from test_env.py, as it is no
> longer needed.
>
> Bug: 362595425, 347350045
> Change-Id: I63d28d2f0fbf39ba0d22be7ac88e140768f33171
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5973241
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Gary Tong <gatong@chromium.org>
> Reviewed-by: Matthew Denton <mpdenton@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1411004}
>
Bug: 362595425, 347350045
Change-Id: I2ef44348b968254882c258ced25a928a3cb5c85f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6199173
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Gary Tong <gatong@chromium.org>
Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1411450}
Sandbox Library
This directory contains platform-specific sandboxing libraries. Sandboxing is a technique that can improve the security of an application by separating untrustworthy code (or code that handles untrustworthy data) and restricting its privileges and capabilities.
Each platform relies on the operating system's process primitive to isolate code into distinct security principals, and platform-specific technologies are used to implement the privilege reduction. At a high-level:
mac/
uses the Seatbelt sandbox. See the detailed design for more.linux/
uses namespaces and Seccomp-BPF. See the detailed design for more.win/
uses a combination of restricted tokens, distinct job objects, alternate desktops, and integrity levels. See the detailed design for more.
Built on top of the low-level sandboxing library is the
//sandbox/policy
component, which provides concrete
policies and helper utilities for sandboxing specific Chromium processes and
services. The core sandbox library cannot depend on the policy component.