
This reverts commit e55b73bf93
.
Reason for revert: TooltipControllerCaptureTest.Capture started failing on Chrome OS builds
Original change's description:
> Have DefaultScreenPositionClient() keep the Aura root window updated.
>
> It sets itself as the root window's client on construction and nulls
> that out on destruction. DesktopScreenPositionClient already did this,
> this just hoists that to the base class.
>
> This makes it harder to introduce bugs like "constructed the client
> but forgot to set it on the window" or the more likely (and insidious)
> "failed to null the client on shutdown, leaking state into another test
> and triggering test flakiness".
>
> Bug: none
> Change-Id: Ib8ddb193d78d7d7e5b0cf48683a7ef9653d31f7c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117335
> Reviewed-by: Darren Shen <shend@chromium.org>
> Reviewed-by: Yuchen Liu <yucliu@chromium.org>
> Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
> Commit-Queue: Darren Shen <shend@chromium.org>
> Auto-Submit: Peter Kasting <pkasting@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#753540}
TBR=sadrul@chromium.org,pkasting@chromium.org,rdevlin.cronin@chromium.org,shend@chromium.org,yucliu@chromium.org
Change-Id: Ia758dbaa0441874217c62cd061cff21aae329740
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1064933
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121259
Reviewed-by: Tim Schumann <tschumann@chromium.org>
Commit-Queue: Tim Schumann <tschumann@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753583}
Cast base
cast_features
This file contains tools for checking the feature state of all of the features which affect Cast products. Cast features build upon the Chrome feature system. Some aspects of Cast require the feature system to work differently, however, so some additional logic has been layered on top. Details are available in comments of the header file. The basics are:
- If you are adding a new feature, add it to
cast_features.cc
so it lives alongside existing features - Add your new feature to the list of
kFeatures
incast_features.cc
const base::Feature kMyFeature{"my_feature", base::FEATURE_DISABLED_BY_DEFAULT};
const base::Feature* kFeatures[] = {
// ..other features
&kMyFeature
}