android_webview
apps
ash
base
build
3pp_common
android
apple
args
chromeos
cipd
config
docs
fuchsia
gn_ast
internal
ios
linux
mac
private_code_test
rust
sanitizers
skia_gold_common
toolchain
aix
android
apple
cros
fuchsia
ios
linux
mac
nacl
win
zos
BUILD.gn
OWNERS
cc_wrapper.gni
check_rewrapper_cfg.py
clang_code_coverage_wrapper.py
concurrent_links.gni
cros_toolchain.gni
gcc_link_wrapper.py
gcc_solink_wrapper.py
gcc_toolchain.gni
get_concurrent_links.py
get_cpu_count.py
kythe.gni
nacl_toolchain.gni
rbe.gni
siso.gni
toolchain.gni
use_reclient_value.py
use_remoteexec_value.py
use_siso_default.py
whole_archive.py
wrapper_utils.py
util
win
.clang-tidy
.clangd
.git-blame-ignore-revs
.gitignore
.style.yapf
BUILD.gn
DEPS
DIR_METADATA
OWNERS
OWNERS.setnoparent
OWNERS.status
PRESUBMIT.py
PRESUBMIT_test.py
README.md
action_helpers.py
action_helpers_unittest.py
add_rts_filters.py
build-ctags.sh
build_config.h
buildflag.h
buildflag_header.gni
check_gn_headers.py
check_gn_headers_allowlist.txt
check_gn_headers_unittest.py
check_return_value.py
ciopfs.sha1
clobber.py
clobber_unittest.py
compiled_action.gni
compute_build_timestamp.py
copy_test_data_ios.py
cp.py
detect_host_arch.py
dir_exists.py
dotfile_settings.gni
download_nacl_toolchains.py
env_dump.py
extract_from_cab.py
extract_partition.py
find_depot_tools.py
fix_gn_headers.py
gdb-add-index
get_landmines.py
get_symlink_targets.py
gn_editor
gn_helpers.py
gn_helpers_unittest.py
gn_logs.gni
gn_run_binary.py
install-build-deps.py
install-build-deps.sh
install-chroot.sh
landmine_utils.py
landmines.py
locale_tool.py
mac_toolchain.py
metadata.json.in
nocompile.gni
noop.py
partitioned_shared_library.gni
precompile.cc
precompile.h
print_python_deps.py
protoc_java.py
protoc_java.pydeps
redirect_stdout.py
rm.py
sample_arg_file.gn
sanitize-mac-build-log.sed
sanitize-mac-build-log.sh
sanitize-win-build-log.sed
sanitize-win-build-log.sh
shim_headers.gni
symlink.gni
symlink.py
timestamp.gni
tree_truth.sh
update-linux-sandbox.sh
vs_toolchain.py
whitespace_file.txt
write_buildflag_header.py
xcode_binaries.yaml
zip_helpers.py
zip_helpers_unittest.py
build_overrides
buildtools
cc
chrome
chromecast
chromeos
clank
codelabs
components
content
crypto
dbus
device
docs
extensions
fuchsia_web
gin
google_apis
gpu
headless
infra
internal
ios
ios_internal
ipc
media
mojo
native_client
native_client_sdk
net
pdf
ppapi
printing
remoting
rlz
sandbox
services
signing_keys
skia
sql
storage
styleguide
testing
third_party
tools
ui
url
v8
webkit
.clang-format
.clang-tidy
.clangd
.git-blame-ignore-revs
.gitallowed
.gitattributes
.gitignore
.gitmodules
.gn
.mailmap
.rustfmt.toml
.vpython3
.yapfignore
ATL_OWNERS
AUTHORS
BUILD.gn
CODE_OF_CONDUCT.md
CPPLINT.cfg
CRYPTO_OWNERS
DEPS
DIR_METADATA
LICENSE
LICENSE.chromium_os
OWNERS
PRESUBMIT.py
PRESUBMIT_test.py
PRESUBMIT_test_mocks.py
README.md
WATCHLISTS
codereview.settings
description
d60ced3a2f
This CL excludes PA from `use_clang_coverage` for code coverage. It was preventing some PA-related changes to land, by adding too much perf overhead. The list is generated by: ``` > find base/allocator/partition_allocator -type f -name "*.cc" ``` We experienced the issue on linux, chromeos, and mac so far. In theory it can occur in any platform, so applying this exclusion everywhere. Bug: 356570413 Change-Id: I3201843368ab845246e90bade7854c110e0dfbdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5850149 Reviewed-by: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Mikihito Matsuura <mikt@google.com> Reviewed-by: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/main@{#1356878}
375 lines
30 KiB
Python
Executable File
375 lines
30 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright 2018 The Chromium Authors
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
"""Removes code coverage flags from invocations of the Clang C/C++ compiler.
|
|
|
|
If the GN arg `use_clang_coverage=true`, this script will be invoked by default.
|
|
GN will add coverage instrumentation flags to almost all source files.
|
|
|
|
This script is used to remove instrumentation flags from a subset of the source
|
|
files. By default, it will not remove flags from any files. If the option
|
|
--files-to-instrument is passed, this script will remove flags from all files
|
|
except the ones listed in --files-to-instrument.
|
|
|
|
This script also contains hard-coded exclusion lists of files to never
|
|
instrument, indexed by target operating system. Files in these lists have their
|
|
flags removed in both modes. The OS can be selected with --target-os.
|
|
|
|
This script also contains hard-coded force lists of files to always instrument,
|
|
indexed by target operating system. Files in these lists never have their flags
|
|
removed in either mode. The OS can be selected with --target-os.
|
|
|
|
The order of precedence is: force list, exclusion list, --files-to-instrument.
|
|
|
|
The path to the coverage instrumentation input file should be relative to the
|
|
root build directory, and the file consists of multiple lines where each line
|
|
represents a path to a source file, and the specified paths must be relative to
|
|
the root build directory. e.g. ../../base/task/post_task.cc for build
|
|
directory 'out/Release'. The paths should be written using OS-native path
|
|
separators for the current platform.
|
|
|
|
One caveat with this compiler wrapper is that it may introduce unexpected
|
|
behaviors in incremental builds when the file path to the coverage
|
|
instrumentation input file changes between consecutive runs, so callers of this
|
|
script are strongly advised to always use the same path such as
|
|
"${root_build_dir}/coverage_instrumentation_input.txt".
|
|
|
|
It's worth noting on try job builders, if the contents of the instrumentation
|
|
file changes so that a file doesn't need to be instrumented any longer, it will
|
|
be recompiled automatically because if try job B runs after try job A, the files
|
|
that were instrumented in A will be updated (i.e., reverted to the checked in
|
|
version) in B, and so they'll be considered out of date by ninja and recompiled.
|
|
|
|
Example usage:
|
|
clang_code_coverage_wrapper.py \\
|
|
--files-to-instrument=coverage_instrumentation_input.txt
|
|
|
|
Siso implements the same logic in
|
|
build/config/siso/clang_code_coverage_wrapper.star, which avoids the wrapper
|
|
invocations for remote execution and performance improvement.
|
|
Please update the Siso starlark file when updating this file.
|
|
"""
|
|
# LINT.IfChange
|
|
|
|
import argparse
|
|
import os
|
|
import subprocess
|
|
import sys
|
|
|
|
# Flags used to enable coverage instrumentation.
|
|
# Flags should be listed in the same order that they are added in
|
|
# build/config/coverage/BUILD.gn
|
|
_COVERAGE_FLAGS = [
|
|
'-fprofile-instr-generate',
|
|
'-fcoverage-mapping',
|
|
'-mllvm',
|
|
'-runtime-counter-relocation=true',
|
|
# Following experimental flags remove unused header functions from the
|
|
# coverage mapping data embedded in the test binaries, and the reduction
|
|
# of binary size enables building Chrome's large unit test targets on
|
|
# MacOS. Please refer to crbug.com/796290 for more details.
|
|
'-mllvm',
|
|
'-limited-coverage-experimental=true',
|
|
]
|
|
|
|
# Files that should not be built with coverage flags by default.
|
|
_DEFAULT_COVERAGE_EXCLUSION_LIST = [
|
|
# These files caused perf regressions, resulting in time-outs on some bots.
|
|
# TODO(https://crbug.com/356570413): Remove when the bug is fixed.
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/address_pool_manager_bitmap.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/address_pool_manager.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/address_pool_manager_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/address_space_randomization.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/address_space_randomization_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/allocation_guard.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/compressed_pointer.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/compressed_pointer_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/dangling_raw_ptr_checks.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/extended_api.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/freeslot_bitmap_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/gwp_asan_support.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/hardening_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/internal_allocator.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/lightweight_quarantine.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/lightweight_quarantine_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/memory_reclaimer.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/memory_reclaimer_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/oom_callback.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/oom.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/page_allocator.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/page_allocator_internals_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/page_allocator_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_address_space.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/apple/mach_logging.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/bits_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/check.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/component_export_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/cpu.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/cpu_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/alias.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/proc_maps_linux.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace_android.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace_linux.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace_mac.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/files/file_path.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/files/file_path_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/files/file_util_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/fuchsia/fuchsia_logging.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/fuchsia/fuchsia_logging_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/logging.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/logging_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/log_message.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/memory/page_size_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/memory/page_size_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/memory/ref_counted.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/native_library.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/native_library_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/native_library_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/no_destructor_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/posix/safe_strerror.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/process/process_handle_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/process/process_handle_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/rand_util.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/rand_util_fuchsia.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/rand_util_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/rand_util_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/rand_util_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/scoped_clear_last_error_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/scoped_clear_last_error_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/safe_sprintf.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/safe_sprintf_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/stringprintf.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/stringprintf_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/string_util.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/string_util_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/thread_annotations_pa_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_android_for_testing.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_fuchsia_for_testing.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_linux_for_testing.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_posix_for_testing.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_win_for_testing.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time_conversion_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time_fuchsia.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time_now_posix.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time_override.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_hooks.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_perftest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_alloc_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_bucket.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_dcheck_helper.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_freelist_entry.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_lock_perftest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_lock_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_oom.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_page.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_root.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_stats.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/partition_tls_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/pointers/empty.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/pointers/instance_tracer.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_asan_unowned_impl.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_backup_ref_impl.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_hookable_impl.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ref_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/random.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/reservation_offset_table.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/reverse_bytes_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_android.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_apple.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_apple_zoned_malloc.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_glibc.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_linker_wrapped_symbols.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_partition_alloc.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_partition_alloc_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_partition_alloc_with_advanced_checks.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_winheap.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_dispatch_to_noop_on_free.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_functions_win_component.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_win_component.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_win_static.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/empty.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/malloc_zone_functions_apple.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/malloc_zone_functions_apple_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/winheap_stubs_win.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/shim/winheap_stubs_win_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/slot_start_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/spinning_mutex.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/stack/asm/arm64/push_registers_asm.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/stack/asm/arm/push_registers_asm.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/stack/asm/riscv64/push_registers_asm.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/stack/asm/x64/push_registers_asm.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/stack/asm/x86/push_registers_asm.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/stack/stack.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/stack/stack_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/tagging.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/tagging_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/thread_cache.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/thread_cache_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/thread_isolation/pkey.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/thread_isolation/pkey_unittest.cc', #pylint: disable=line-too-long
|
|
'../../base/allocator/partition_allocator/src/partition_alloc/thread_isolation/thread_isolation.cc', #pylint: disable=line-too-long
|
|
]
|
|
|
|
# Map of exclusion lists indexed by target OS.
|
|
# If no target OS is defined, or one is defined that doesn't have a specific
|
|
# entry, use _DEFAULT_COVERAGE_EXCLUSION_LIST.
|
|
_COVERAGE_EXCLUSION_LIST_MAP = {
|
|
'android': [
|
|
# This file caused webview native library failed on arm64.
|
|
'../../device/gamepad/dualshock4_controller.cc',
|
|
] + _DEFAULT_COVERAGE_EXCLUSION_LIST,
|
|
'fuchsia': [
|
|
# TODO(crbug.com/40167659): These files caused clang to crash while
|
|
# compiling them.
|
|
'../../third_party/skia/src/core/SkOpts.cpp',
|
|
'../../third_party/skia/src/opts/SkOpts_hsw.cpp',
|
|
'../../third_party/skia/third_party/skcms/skcms.cc',
|
|
] + _DEFAULT_COVERAGE_EXCLUSION_LIST,
|
|
'linux': [
|
|
# These files caused a static initializer to be generated, which
|
|
# shouldn't.
|
|
# TODO(crbug.com/41474559): Remove when the bug is fixed.
|
|
'../../chrome/browser/media/router/providers/cast/cast_internal_message_util.cc', #pylint: disable=line-too-long
|
|
'../../components/media_router/common/providers/cast/channel/cast_channel_enum.cc', #pylint: disable=line-too-long
|
|
'../../components/media_router/common/providers/cast/channel/cast_message_util.cc', #pylint: disable=line-too-long
|
|
'../../components/media_router/common/providers/cast/cast_media_source.cc', #pylint: disable=line-too-long
|
|
'../../ui/events/keycodes/dom/keycode_converter.cc',
|
|
] + _DEFAULT_COVERAGE_EXCLUSION_LIST,
|
|
'chromeos': [
|
|
# These files caused clang to crash while compiling them. They are
|
|
# excluded pending an investigation into the underlying compiler bug.
|
|
'../../third_party/webrtc/p2p/base/p2p_transport_channel.cc',
|
|
'../../third_party/icu/source/common/uts46.cpp',
|
|
'../../third_party/icu/source/common/ucnvmbcs.cpp',
|
|
'../../base/android/android_image_reader_compat.cc',
|
|
] + _DEFAULT_COVERAGE_EXCLUSION_LIST,
|
|
}
|
|
|
|
# Map of force lists indexed by target OS.
|
|
_COVERAGE_FORCE_LIST_MAP = {
|
|
# clang_profiling.cc refers to the symbol `__llvm_profile_dump` from the
|
|
# profiling runtime. In a partial coverage build, it is possible for a
|
|
# binary to include clang_profiling.cc but have no instrumented files, thus
|
|
# causing an unresolved symbol error because the profiling runtime will not
|
|
# be linked in. Therefore we force coverage for this file to ensure that
|
|
# any target that includes it will also get the profiling runtime.
|
|
'win': [r'..\..\base\test\clang_profiling.cc'],
|
|
# TODO(crbug.com/40154378) We're seeing runtime LLVM errors in mac-rel when
|
|
# no files are changed, so we suspect that this is similar to the other
|
|
# problem with clang_profiling.cc on Windows. The TODO here is to force
|
|
# coverage for this specific file on ALL platforms, if it turns out to fix
|
|
# this issue on Mac as well. It's the only file that directly calls
|
|
# `__llvm_profile_dump` so it warrants some special treatment.
|
|
'mac': ['../../base/test/clang_profiling.cc'],
|
|
}
|
|
|
|
|
|
def _remove_flags_from_command(command):
|
|
# We need to remove the coverage flags for this file, but we only want to
|
|
# remove them if we see the exact sequence defined in _COVERAGE_FLAGS.
|
|
# That ensures that we only remove the flags added by GN when
|
|
# "use_clang_coverage" is true. Otherwise, we would remove flags set by
|
|
# other parts of the build system.
|
|
start_flag = _COVERAGE_FLAGS[0]
|
|
num_flags = len(_COVERAGE_FLAGS)
|
|
start_idx = 0
|
|
try:
|
|
while True:
|
|
idx = command.index(start_flag, start_idx)
|
|
if command[idx:idx + num_flags] == _COVERAGE_FLAGS:
|
|
del command[idx:idx + num_flags]
|
|
# There can be multiple sets of _COVERAGE_FLAGS. All of these need to be
|
|
# removed.
|
|
start_idx = idx
|
|
else:
|
|
start_idx = idx + 1
|
|
except ValueError:
|
|
pass
|
|
|
|
|
|
def main():
|
|
arg_parser = argparse.ArgumentParser()
|
|
arg_parser.usage = __doc__
|
|
arg_parser.add_argument(
|
|
'--files-to-instrument',
|
|
type=str,
|
|
help='Path to a file that contains a list of file names to instrument.')
|
|
arg_parser.add_argument(
|
|
'--target-os', required=False, help='The OS to compile for.')
|
|
arg_parser.add_argument('args', nargs=argparse.REMAINDER)
|
|
parsed_args = arg_parser.parse_args()
|
|
|
|
if (parsed_args.files_to_instrument and
|
|
not os.path.isfile(parsed_args.files_to_instrument)):
|
|
raise Exception('Path to the coverage instrumentation file: "%s" doesn\'t '
|
|
'exist.' % parsed_args.files_to_instrument)
|
|
|
|
compile_command = parsed_args.args
|
|
if not any('clang' in s for s in compile_command):
|
|
return subprocess.call(compile_command)
|
|
|
|
target_os = parsed_args.target_os
|
|
|
|
try:
|
|
# The command is assumed to use Clang as the compiler, and the path to the
|
|
# source file is behind the -c argument, and the path to the source path is
|
|
# relative to the root build directory. For example:
|
|
# clang++ -fvisibility=hidden -c ../../base/files/file_path.cc -o \
|
|
# obj/base/base/file_path.o
|
|
# On Windows, clang-cl.exe uses /c instead of -c.
|
|
source_flag = '/c' if target_os == 'win' else '-c'
|
|
source_flag_index = compile_command.index(source_flag)
|
|
except ValueError:
|
|
print('%s argument is not found in the compile command.' % source_flag)
|
|
raise
|
|
|
|
if source_flag_index + 1 >= len(compile_command):
|
|
raise Exception('Source file to be compiled is missing from the command.')
|
|
|
|
# On Windows, filesystem paths should use '\', but GN creates build commands
|
|
# that use '/'. We invoke os.path.normpath to ensure that the path uses the
|
|
# correct separator for the current platform (i.e. '\' on Windows and '/'
|
|
# otherwise).
|
|
compile_source_file = os.path.normpath(compile_command[source_flag_index + 1])
|
|
extension = os.path.splitext(compile_source_file)[1]
|
|
if not extension in ['.c', '.cc', '.cpp', '.cxx', '.m', '.mm', '.S']:
|
|
raise Exception('Invalid source file %s found' % compile_source_file)
|
|
exclusion_list = _COVERAGE_EXCLUSION_LIST_MAP.get(
|
|
target_os, _DEFAULT_COVERAGE_EXCLUSION_LIST)
|
|
force_list = _COVERAGE_FORCE_LIST_MAP.get(target_os, [])
|
|
|
|
should_remove_flags = False
|
|
if compile_source_file not in force_list:
|
|
if compile_source_file in exclusion_list:
|
|
should_remove_flags = True
|
|
elif parsed_args.files_to_instrument:
|
|
with open(parsed_args.files_to_instrument) as f:
|
|
if compile_source_file not in f.read():
|
|
should_remove_flags = True
|
|
|
|
if should_remove_flags:
|
|
_remove_flags_from_command(compile_command)
|
|
|
|
return subprocess.call(compile_command)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
sys.exit(main())
|
|
|
|
# LINT.ThenChange(/build/config/siso/clang_code_coverage_wrapper.star)
|