
This reverts commit 20ff3edd59
.
Reason for revert: Breaking in V8
File "/usr/local/google/home/leszeks/v8/v8/buildtools/checkdeps/builddeps.py", line 373, in _IterSelfAndParentDirectories
assert parent != current_dir_name, (
^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError: /usr/local/google/home/leszeks/third_party/inspector_protocol/crdtp, /usr/local/google/home/leszeks/v8/v8, /
Original change's description:
> checkdeps: Teach it about new_usages_require_review
>
> This will cause checkdeps to fail if an include is added to a directory
> that lists new_usages_require_review=True in its DEPS, but contains
> include_dirs entries only for ancestor directories.
>
> Bug: 365797506
> Change-Id: Ib6ccaf6d65bb869ff13f8f3c7722146fc7ad5317
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5953099
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Owners-Override: Andrew Grieve <agrieve@chromium.org>
> Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> Reviewed-by: David Benjamin <davidben@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1386478}
Bug: 365797506
Change-Id: I14e1f734359ad87927a6557a6ff2687acc0fe063
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6043338
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1386859}
This directory contains hashes of build tools used by Chromium and related projects. The actual binaries are pulled from Google Storage, normally as part of a gclient hook. This directory also exists as a stand-alone git mirror at https://chromium.googlesource.com/chromium/src/buildtools/. That mirror exists so that the shared build tools can be shared between the various Chromium-related projects without each one needing to maintain their own versionining of each binary. ________________________ ADDING BINARIES MANUALLY One uploads new versions of the tools using the 'gsutil' binary from the Google Storage SDK: https://developers.google.com/storage/docs/gsutil There is a checked-in version of gsutil as part of depot_tools. To initialize gsutil's credentials: python ~/depot_tools/third_party/gsutil/gsutil config That will give a URL which you should log into with your web browser. Copy the code back to the command line util. Ignore the project ID (it's OK to just leave blank when prompted).