Usage of AssertBlockingAllowed outside of base:: is being replaced by
ScopedBlockingCall.
This CL puts AssertBlockingAllowed() into base::internal and
adds AssertBlockingAllowedDeprecated for compatibility with current usage.
This is a purely mechanical change with no side-effects.
TBR=fdoray@chromium.org
Bug: 874080
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I2b482a5ca217a563052dcae4afc45553626aa3d3
Reviewed-on: https://chromium-review.googlesource.com/c/1278540
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600793}
Contains a written down set of principles and other information on //base.
Please add to it!
About //base:
Chromium is a very mature project. Most things that are generally useful are
already here and things not here aren't generally useful.
Base is pulled into many projects. For example, various ChromeOS daemons. So
the bar for adding stuff is that it must have demonstrated wide
applicability. Prefer to add things closer to where they're used (i.e. "not
base"), and pull into base only when needed. In a project our size,
sometimes even duplication is OK and inevitable.
Adding a new logging macro DPVELOG_NE is not more clear than just
writing the stuff you want to log in a regular logging statement, even
if it makes your calling code longer. Just add it to your own code.
If the code in question does not need to be used inside base, but will have
multiple consumers across the codebase, consider placing it in a new directory
under components/ instead.
Qualifications for being in //base OWNERS
interest and ability to learn low level/high detail/complex c++ stuff
inclination to always ask why and understand everything (including external
interactions like win32) rather than just hoping the author did it right
mentorship/experience
demonstrated good judgement (esp with regards to public APIs) over a length
of time
Owners are added when a contributor has shown the above qualifications and
when they express interest. There isn't an upper bound on the number of OWNERS.
a4195e59f5