0
Files
src/gin/v8_initializer.h
Josh Gao 79f75279db Fix fd ownership mismanagement in V8 initialization.
gin::V8Initializer::LoadV8SnapshotFromFD and LoadV8NativesFromFD were
accepting a base::PlatformFile owned by a File and then passing it into
MemoryMappedFile::Initialize, which constructs another owning base::File
from the PlatformFile.

Refactor the functions to take base::File instead, and delete some code
that was maintaining a cache that only ever missed.

Bug: 884034
Change-Id: I2758bc45de63ee4d34dcd5a4b806f1806e25e4f8
Reviewed-on: https://chromium-review.googlesource.com/c/1247322
Commit-Queue: Josh Gao <jmgao@google.com>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#596775}
2018-10-04 18:37:45 +00:00

82 lines
2.9 KiB
C++

// Copyright 2013 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#ifndef GIN_V8_INITIALIZER_H_
#define GIN_V8_INITIALIZER_H_
#include <stdint.h>
#include "base/files/file.h"
#include "base/files/memory_mapped_file.h"
#include "gin/array_buffer.h"
#include "gin/gin_export.h"
#include "gin/public/isolate_holder.h"
#include "gin/public/v8_platform.h"
#include "v8/include/v8.h"
namespace gin {
class GIN_EXPORT V8Initializer {
public:
// This should be called by IsolateHolder::Initialize().
static void Initialize(IsolateHolder::ScriptMode mode,
IsolateHolder::V8ExtrasMode v8_extras_mode);
// Get address and size information for currently loaded snapshot.
// If no snapshot is loaded, the return values are null for addresses
// and 0 for sizes.
static void GetV8ExternalSnapshotData(v8::StartupData* natives,
v8::StartupData* snapshot);
static void GetV8ExternalSnapshotData(const char** natives_data_out,
int* natives_size_out,
const char** snapshot_data_out,
int* snapshot_size_out);
#if defined(V8_USE_EXTERNAL_STARTUP_DATA)
// Indicates which file to load as a snapshot blob image.
enum class V8SnapshotFileType {
kDefault,
// Snapshot augmented with customized contexts, which can be deserialized
// using v8::Context::FromSnapshot.
kWithAdditionalContext,
};
// Load V8 snapshot from default resources, if they are available.
static void LoadV8Snapshot(
V8SnapshotFileType snapshot_file_type = V8SnapshotFileType::kDefault);
// Load V8 natives source from default resources. Contains asserts
// so that it will not return if natives cannot be loaded.
static void LoadV8Natives();
// Load V8 snapshot from user provided file.
// The region argument, if non-zero, specifies the portions
// of the files to be mapped. Since the VM can boot with or without
// the snapshot, this function does not return a status.
static void LoadV8SnapshotFromFile(
base::File snapshot_file,
base::MemoryMappedFile::Region* snapshot_file_region,
V8SnapshotFileType snapshot_file_type);
// Similar to LoadV8SnapshotFromFile, but for the source of the natives.
// Without the natives we cannot continue, so this function contains
// release mode asserts and won't return if it fails.
static void LoadV8NativesFromFile(
base::File natives_file,
base::MemoryMappedFile::Region* natives_file_region);
#if defined(OS_ANDROID)
static base::FilePath GetNativesFilePath();
static base::FilePath GetSnapshotFilePath(
bool abi_32_bit,
V8SnapshotFileType snapshot_file_type);
#endif
#endif // V8_USE_EXTERNAL_STARTUP_DATA
};
} // namespace gin
#endif // GIN_V8_INITIALIZER_H_