0
Files
src/components/javascript_dialogs
Andrew Grieve 81090fd5b0 Remove @VisibleForTesting from ForTesting methods
and disable the related lint check. The lint check fails because
it does not recognize that a "ForTest" method without the annotation
is allowed to call other @VisibleForTesting methods (e.g. those
without the ForTesting suffix).

Not using the annotation for ForTesting methods was recently added to
the style guide (0872aad0a7).

This fixing existing violations. I used the following script:

import re
import sys
C = open(sys.argv[1], encoding='utf8').read()
if '@VisibleForTesting' in C:
  C = re.sub(r' +@VisibleForTesting.*\n(\s+.*ForTest\S*\()', r'\1', C)
  open(sys.argv[1], mode='w', encoding='utf8').write(C)

Bug: None
Change-Id: I80c695d48425ce639feb4184ecd1f4c82d0f7903
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4705304
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Owners-Override: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1173291}
2023-07-21 02:25:40 +00:00
..