0
Files
android_webview
apps
ash
base
allocator
android
apple
containers
debug
files
fuchsia
functional
hash
i18n
ios
json
logging
mac
macros
memory
message_loop
metrics
nix
numerics
posix
power_monitor
process
profiler
sampling_heap_profiler
strings
abseil_string_number_conversions.cc
abseil_string_number_conversions.h
abseil_string_number_conversions_unittest.cc
cstring_view.h
cstring_view_nocompile.nc
cstring_view_unittest.cc
escape.cc
escape.h
escape_fuzzer.cc
escape_unittest.cc
latin1_string_conversions.cc
latin1_string_conversions.h
levenshtein_distance.cc
levenshtein_distance.h
levenshtein_distance_unittest.cc
no_trigraphs_unittest.cc
pattern.cc
pattern.h
pattern_fuzzer.cc
pattern_unittest.cc
safe_sprintf.cc
safe_sprintf.h
safe_sprintf_unittest.cc
span_printf.h
span_printf_nocompile.nc
span_printf_unittest.cc
strcat.cc
strcat.h
strcat_internal.h
strcat_unittest.cc
strcat_win.cc
strcat_win.h
string_number_conversions.cc
string_number_conversions.h
string_number_conversions_fuzzer.cc
string_number_conversions_internal.h
string_number_conversions_unittest.cc
string_number_conversions_win.cc
string_number_conversions_win.h
string_piece_rust_unittest.cc
string_slice.h
string_slice_unittest.cc
string_split.cc
string_split.h
string_split_internal.h
string_split_nocompile.nc
string_split_unittest.cc
string_split_win.cc
string_split_win.h
string_tokenizer.h
string_tokenizer_fuzzer.cc
string_tokenizer_unittest.cc
string_util.cc
string_util.h
string_util_constants.cc
string_util_impl_helpers.h
string_util_internal.h
string_util_perftest.cc
string_util_posix.h
string_util_unittest.cc
string_util_win.cc
string_util_win.h
string_view_rust.h
stringize_macros.h
stringize_macros_unittest.cc
stringprintf.cc
stringprintf.h
stringprintf_unittest.cc
sys_string_conversions.h
sys_string_conversions_apple.mm
sys_string_conversions_apple_unittest.mm
sys_string_conversions_fuzzer.cc
sys_string_conversions_posix.cc
sys_string_conversions_unittest.cc
sys_string_conversions_win.cc
to_string.h
to_string_unittest.cc
utf_offset_string_conversions.cc
utf_offset_string_conversions.h
utf_offset_string_conversions_unittest.cc
utf_ostream_operators.cc
utf_ostream_operators.h
utf_string_conversion_utils.cc
utf_string_conversion_utils.h
utf_string_conversion_utils_unittest.cc
utf_string_conversions.cc
utf_string_conversions.h
utf_string_conversions_fuzzer.cc
utf_string_conversions_unittest.cc
substring_set_matcher
synchronization
system
task
test
third_party
threading
time
timer
trace_event
tracing
types
version_info
win
BUILD.gn
DEPS
DIR_METADATA
OWNERS
PRESUBMIT.py
README.md
SECURITY_OWNERS
at_exit.cc
at_exit.h
at_exit_unittest.cc
atomic_ref_count.h
atomic_sequence_num.h
atomicops.cc
atomicops.h
atomicops_internals_atomicword_compat.h
atomicops_internals_portable.h
atomicops_unittest.cc
auto_reset.h
auto_reset_unittest.cc
barrier_callback.h
barrier_callback_unittest.cc
barrier_closure.cc
barrier_closure.h
barrier_closure_unittest.cc
base64.cc
base64.h
base64_decode_fuzzer.cc
base64_encode_fuzzer.cc
base64_unittest.cc
base64url.cc
base64url.h
base64url_fuzzer.cc
base64url_unittest.cc
base_export.h
base_paths.cc
base_paths.h
base_paths_android.cc
base_paths_android.h
base_paths_apple.cc
base_paths_apple.h
base_paths_fuchsia.cc
base_paths_ios.h
base_paths_ios.mm
base_paths_mac.h
base_paths_mac.mm
base_paths_posix.cc
base_paths_posix.h
base_paths_win.cc
base_paths_win.h
base_switches.cc
base_switches.h
big_endian.h
big_endian_perftest.cc
bit_cast.h
bit_cast_unittest.cc
bits.h
bits_unittest.cc
build_time.h
build_time_unittest.cc
callback_list.cc
callback_list.h
callback_list_nocompile.nc
callback_list_unittest.cc
cancelable_callback.h
cancelable_callback_unittest.cc
check.cc
check.h
check_deref.h
check_example.cc
check_is_test.cc
check_is_test.h
check_is_test_unittest.cc
check_nocompile.nc
check_op.cc
check_op.h
check_unittest.cc
check_version_internal.h.in
command_line.cc
command_line.h
command_line_fuzzer.cc
command_line_unittest.cc
compiler_specific.h
component_export.h
component_export_unittest.cc
cpu.cc
cpu.h
cpu_unittest.cc
critical_closure.h
critical_closure_internal_ios.mm
dcheck_is_on.h
enterprise_util.cc
enterprise_util.h
enterprise_util_mac.mm
enterprise_util_mac_unittest.mm
enterprise_util_win.cc
environment.cc
environment.h
environment_unittest.cc
export_template.h
feature_list.cc
feature_list.h
feature_list_unittest.cc
feature_visitor.h
features.cc
features.h
file_descriptor_posix.cc
file_descriptor_posix.h
file_descriptor_store.cc
file_descriptor_store.h
file_version_info.h
file_version_info_apple.h
file_version_info_apple.mm
file_version_info_win.cc
file_version_info_win.h
file_version_info_win_unittest.cc
format_macros.h
gmock_unittest.cc
gtest_prod_util.h
immediate_crash.h
immediate_crash_unittest.cc
lazy_instance.h
lazy_instance_helpers.cc
lazy_instance_helpers.h
lazy_instance_unittest.cc
libcpp_hardening_test.cc
linux_util.cc
linux_util.h
linux_util_unittest.cc
location.cc
location.h
location_unittest.cc
logging.cc
logging.h
logging_chromeos.cc
logging_nocompile.nc
logging_unittest.cc
logging_win.cc
logging_win.h
moving_window.h
moving_window_unittest.cc
native_library.cc
native_library.h
native_library_apple.mm
native_library_fuchsia.cc
native_library_posix.cc
native_library_unittest.cc
native_library_win.cc
no_destructor.h
no_destructor_nocompile.nc
no_destructor_unittest.cc
not_fatal_until.h
notimplemented.h
notreached.h
observer_list.h
observer_list_internal.cc
observer_list_internal.h
observer_list_nocompile.nc
observer_list_perftest.cc
observer_list_threadsafe.cc
observer_list_threadsafe.h
observer_list_threadsafe_unittest.cc
observer_list_types.cc
observer_list_types.h
observer_list_unittest.cc
one_shot_event.cc
one_shot_event.h
one_shot_event_unittest.cc
os_compat_android.cc
os_compat_android.h
os_compat_nacl.cc
os_compat_nacl.h
parameter_pack.h
parameter_pack_unittest.cc
path_service.cc
path_service.h
path_service_unittest.cc
pending_task.cc
pending_task.h
pickle.cc
pickle.h
pickle_fuzzer.cc
pickle_unittest.cc
rand_util.cc
rand_util.h
rand_util_fuchsia.cc
rand_util_nacl.cc
rand_util_perftest.cc
rand_util_posix.cc
rand_util_unittest.cc
rand_util_win.cc
run_loop.cc
run_loop.h
run_loop_nocompile.nc
run_loop_unittest.cc
safe_numerics_nocompile.nc
safe_numerics_unittest.cc
scoped_add_feature_flags.cc
scoped_add_feature_flags.h
scoped_add_feature_flags_unittest.cc
scoped_clear_last_error.h
scoped_clear_last_error_unittest.cc
scoped_clear_last_error_win.cc
scoped_environment_variable_override.cc
scoped_environment_variable_override.h
scoped_generic.h
scoped_generic_unittest.cc
scoped_multi_source_observation.h
scoped_multi_source_observation_unittest.cc
scoped_native_library.cc
scoped_native_library.h
scoped_native_library_unittest.cc
scoped_observation.h
scoped_observation_traits.h
scoped_observation_unittest.cc
security_unittest.cc
sequence_checker.cc
sequence_checker.h
sequence_checker_impl.cc
sequence_checker_impl.h
sequence_checker_nocompile.nc
sequence_checker_unittest.cc
sequence_token.cc
sequence_token.h
sequence_token_unittest.cc
stack_canary_linux.cc
stack_canary_linux.h
stack_canary_linux_unittest.cc
state_transitions.h
state_transitions_unittest.cc
std_clamp_unittest.cc
stl_util.h
stl_util_unittest.cc
supports_user_data.cc
supports_user_data.h
supports_user_data_unittest.cc
sync_socket.cc
sync_socket.h
sync_socket_nacl.cc
sync_socket_posix.cc
sync_socket_unittest.cc
sync_socket_win.cc
sys_byteorder.h
sys_byteorder_unittest.cc
syslog_logging.cc
syslog_logging.h
thread_annotations.h
thread_annotations_nocompile.nc
thread_annotations_unittest.cc
token.cc
token.h
token_unittest.cc
tools_sanity_unittest.cc
traits_bag.h
traits_bag_nocompile.nc
traits_bag_unittest.cc
tuple.h
tuple_unittest.cc
unguessable_token.cc
unguessable_token.h
unguessable_token_unittest.cc
unsafe_buffers_nocompile.nc
unsafe_buffers_unittest.cc
uuid.cc
uuid.h
uuid_unittest.cc
value_iterators.cc
value_iterators.h
value_iterators_unittest.cc
values.cc
values.h
values_nocompile.nc
values_unittest.cc
version.cc
version.h
version_unittest.cc
vlog.cc
vlog.h
vlog_unittest.cc
write_build_date_header.py
build
build_overrides
buildtools
cc
chrome
chromecast
chromeos
clank
codelabs
components
content
crypto
dbus
device
docs
extensions
fuchsia_web
gin
google_apis
gpu
headless
infra
internal
ios
ios_internal
ipc
media
mojo
native_client
native_client_sdk
net
pdf
ppapi
printing
remoting
rlz
sandbox
services
signing_keys
skia
sql
storage
styleguide
testing
third_party
tools
ui
url
v8
webkit
.clang-format
.clang-tidy
.clangd
.git-blame-ignore-revs
.gitallowed
.gitattributes
.gitignore
.gitmodules
.gn
.mailmap
.rustfmt.toml
.vpython3
.yapfignore
ATL_OWNERS
AUTHORS
BUILD.gn
CODE_OF_CONDUCT.md
CPPLINT.cfg
CRYPTO_OWNERS
DEPS
DIR_METADATA
LICENSE
LICENSE.chromium_os
OWNERS
PRESUBMIT.py
PRESUBMIT_test.py
PRESUBMIT_test_mocks.py
README.md
WATCHLISTS
codereview.settings
src/base/strings
Lei Zhang a988705d0e Fix base::Base64Decode() regression
In https://crrev.com/1421764, removing the NUL character from
`base::kInfraAsciiWhitespace` made the usage of this constant in
base::Base64Decode() incorrect, as the 1-param std::string_view ctor
requires a null-terminated string. Somehow this got lucky and passed try
bots, but caused a Windows + debug bot to fail. Fix the issue by
switcihng to a 2-params std::string_view ctor that takes begin/end
iterators.

Change-Id: I5fe6ea97e125908d7e70a64e9a9a6dc371aa0681
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6283125
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1422142}
2025-02-19 12:26:41 -08:00
..
2024-12-27 18:30:09 -08:00
2024-12-27 18:30:09 -08:00
2024-12-27 18:30:09 -08:00
2024-12-27 18:30:09 -08:00
2024-12-27 18:30:09 -08:00