f4d6a45f21
This CL:
1) Replaces GN variable used to filter //third_party/android_deps
dependencies with a new GN variable - limit_android_deps
The new GN variable is needed because:
- angle does not use JUnit tests. The standalone angle checkout should
not require //third_party/robolectric for "gn gen" to work.
- webrtc does use JUnit tests and thus requires
//third_party/robolectric
This change fixes the standalone WebRTC breakage caused by
https://chromium-review.googlesource.com/c/chromium/src/+/2812340
2) Removes build_with_chromium requirement for _generate_final_jni
in android_apk_or_module() GN template. This change is needed because
the standalone webrtc build uses JNI. Angle will set
"generate_final_jni" GN variable to avoid //base dependency.
WebRTC bug:12634
Change-Id: I4ad86f33dfea32cb2fb4632e83ab14c0f9f7f4b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2815530
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#871341}
Build overrides in GN
This directory is used to allow different products to customize settings for repos that are DEPS'ed in or shared.
For example: V8 could be built on its own (in a "standalone" configuration),
and it could be built as part of Chromium. V8 might define a top-level
target, //v8:d8 (a simple executable), that should only be built in the
standalone configuration. To figure out whether or not it should be
in a standalone configuration, v8 can create a file, build_overrides/v8.gni,
that contains a variable, build_standalone_d8 = true.
and import it (as import("//build_overrides/v8.gni") from its top-level
BUILD.gn file.
Chromium, on the other hand, might not need to build d8, and so it would
create its own build_overrides/v8.gni file, and in it set
build_standalone_d8 = false.
The two files should define the same set of variables, but the values can vary as appropriate to the needs of the two different builds.
The build.gni file provides a way for projects to override defaults for variables used in //build itself (which we want to be shareable between projects).
TODO(crbug.com/588513): Ideally //build_overrides and, in particular, //build_overrides/build.gni should go away completely in favor of some mechanism that can re-use other required files like //.gn, so that we don't have to keep requiring projects to create a bunch of different files to use GN.