49a903ab69
This is a reland of 525b30ab9b
This reland removes the call to GetDBOptions() from the DatabaseTest
constructor, which was flagged as undefined behavior by the ubsan-vptr
bot. sql::Database construction is deferred to the SetUp() method by
turning the test's sql::Database member into a
std::unique_ptr<sql::Database>.
Original change's description:
> sql: Remove SQLTestBase.
>
> Change-Id: I87bf9499ef590b006660d3b8ab305b0192ec405c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2866306
> Auto-Submit: Victor Costan <pwnall@chromium.org>
> Commit-Queue: Ayu Ishii <ayui@chromium.org>
> Reviewed-by: Ayu Ishii <ayui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#879443}
Change-Id: Ie83bf28eaebb88883b9eb37a7d8407e8bfc619ad
Cq-Do-Not-Cancel-Tryjobs: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2878638
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#880595}
45 lines
1.2 KiB
C++
45 lines
1.2 KiB
C++
// Copyright 2015 The Chromium Authors. All rights reserved.
|
|
// Use of this source code is governed by a BSD-style license that can be
|
|
// found in the LICENSE file.
|
|
|
|
#include "sql/sql_memory_dump_provider.h"
|
|
|
|
#include "base/files/scoped_temp_dir.h"
|
|
#include "base/trace_event/memory_dump_request_args.h"
|
|
#include "base/trace_event/process_memory_dump.h"
|
|
#include "sql/database.h"
|
|
#include "testing/gtest/include/gtest/gtest.h"
|
|
|
|
namespace sql {
|
|
|
|
namespace {
|
|
|
|
class SQLMemoryDumpProviderTest : public testing::Test {
|
|
public:
|
|
~SQLMemoryDumpProviderTest() override = default;
|
|
|
|
void SetUp() override {
|
|
ASSERT_TRUE(temp_dir_.CreateUniqueTempDir());
|
|
ASSERT_TRUE(db_.Open(
|
|
temp_dir_.GetPath().AppendASCII("memory_dump_provider_test.sqlite")));
|
|
|
|
ASSERT_TRUE(db_.Execute("CREATE TABLE foo (a, b)"));
|
|
}
|
|
|
|
protected:
|
|
base::ScopedTempDir temp_dir_;
|
|
Database db_;
|
|
};
|
|
|
|
TEST_F(SQLMemoryDumpProviderTest, OnMemoryDump) {
|
|
base::trace_event::MemoryDumpArgs args = {
|
|
base::trace_event::MemoryDumpLevelOfDetail::DETAILED};
|
|
base::trace_event::ProcessMemoryDump pmd(args);
|
|
ASSERT_TRUE(SqlMemoryDumpProvider::GetInstance()->OnMemoryDump(args, &pmd));
|
|
ASSERT_TRUE(pmd.GetAllocatorDump("sqlite"));
|
|
}
|
|
|
|
} // namespace
|
|
|
|
} // namespace sql
|