1f420da6e9
After https://crrev.com/c/4633730, this presubmit has been complaining with: ** Presubmit Warnings: 1 ** Out of 47 files, found none that matched c=['^.+_unittest\\.py$'], s=['test_env_unittest.py', 'xvfb_unittest.py'] in directory . Turns out those two unittests were the only thing being invoked via this RunUnitTestsInDirectory call. So this just removes it all together. If someone adds a future unittest, they'll need to restore this call. Change-Id: Ieddd60da2af37a09afe583fffa9d8e32943ec9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4641399 Commit-Queue: Ben Pastene <bpastene@chromium.org> Reviewed-by: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/main@{#1161930}
66 lines
2.3 KiB
Python
66 lines
2.3 KiB
Python
# Copyright 2012 The Chromium Authors
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
"""Top-level presubmit script for testing.
|
|
|
|
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
|
|
for more details on the presubmit API built into depot_tools.
|
|
"""
|
|
|
|
PRESUBMIT_VERSION = '2.0.0'
|
|
|
|
|
|
def _GetTestingEnv(input_api):
|
|
"""Gets the common environment for running testing/ tests."""
|
|
testing_env = dict(input_api.environ)
|
|
testing_path = input_api.PresubmitLocalPath()
|
|
# TODO(crbug.com/1358733): This is temporary till gpu code in
|
|
# flake_suppressor_commonis moved to gpu dir.
|
|
# Only common code will reside under /testing.
|
|
gpu_test_path = input_api.os_path.join(
|
|
input_api.PresubmitLocalPath(), '..', 'content', 'test', 'gpu')
|
|
testing_env.update({
|
|
'PYTHONPATH': input_api.os_path.pathsep.join(
|
|
[testing_path, gpu_test_path]),
|
|
'PYTHONDONTWRITEBYTECODE': '1',
|
|
})
|
|
return testing_env
|
|
|
|
|
|
def CheckFlakeSuppressorCommonUnittests(input_api, output_api):
|
|
"""Runs unittests in the testing/flake_suppressor_common/ directory."""
|
|
return input_api.canned_checks.RunUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
input_api.os_path.join(input_api.PresubmitLocalPath(),
|
|
'flake_suppressor_common'),
|
|
[r'^.+_unittest\.py$'],
|
|
env=_GetTestingEnv(input_api))
|
|
|
|
|
|
def CheckUnexpectedPassesCommonUnittests(input_api, output_api):
|
|
"""Runs unittests in the testing/unexpected_passes_common/ directory."""
|
|
return input_api.canned_checks.RunUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
input_api.os_path.join(input_api.PresubmitLocalPath(),
|
|
'unexpected_passes_common'),
|
|
[r'^.+_unittest\.py$'],
|
|
env=_GetTestingEnv(input_api))
|
|
|
|
|
|
def CheckPylint(input_api, output_api):
|
|
"""Runs pylint on all directory content and subdirectories."""
|
|
files_to_skip = input_api.DEFAULT_FILES_TO_SKIP
|
|
if input_api.is_windows:
|
|
# These scripts don't run on Windows and should not be linted on Windows -
|
|
# trying to do so will lead to spurious errors.
|
|
files_to_skip += ('xvfb.py', '.*host_info.py')
|
|
pylint_checks = input_api.canned_checks.GetPylint(
|
|
input_api,
|
|
output_api,
|
|
files_to_skip=files_to_skip,
|
|
version='2.7')
|
|
return input_api.RunTests(pylint_checks)
|