51b9b254a0
tools/python/llvm_symbolizer.py generates error logs, which when called from the stack symbolization scripts can produce a lot of unhelpful logs, notably the error logged when the |lib| parameter of |GetSymbolInformation| is not valid: "Can't run llvm-symbolizer! Given binary is not a valid target. path=%s" See for instance these logs: https://chromium-swarm.appspot.com/task?id=61a979f2cac67b10&w=true This intents to silence most of those errors, especially for the test bots, by updating the stack tool: third_party/android_platform/development/scripts/stack et al. This prevent calls to |GetSymbolInformation| if: - the library is not a .so file - the library is not a valid file Logs are produced only if the script is run in verbose mode. Bug: 1340999 Change-Id: I36e21e6f0567809297e83002722743dda30288f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4444157 Reviewed-by: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/main@{#1139389}
//tools/python
This directory is meant to contain Python code that is:
- Not platform-specific (e.g.
//tools/android/python_utils). - Useful to multiple other tools.
All Python code that is used by GN actions or templates within //build must
live under //build, since that directory cannot have deps outside of it.
However, code here can be used by GN actions or templates that live outside of
//build.
When adding code to this directory, or when adding a dep onto code that lives in this directory, please consider whether or not duplicating the code would actually a better choice. Code re-use is helpful, but dependencies also come with a cost, especially when it comes to being able to test changes to shared code.