
The *_unittest.py and unexpected_passes_common/*_unittest.py scripts have been running under Python 3 for a few weeks (some longer) without problems so it seems reasonable to switch them to Python 2 only, to drive down the Python 2 invocations during the presubmits. Bug: 1313804 Change-Id: Iafb24ed77c98e2821e59ac788d9fa15cea51eb29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3674656 Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/main@{#1009132}
59 lines
1.7 KiB
Python
59 lines
1.7 KiB
Python
# Copyright (c) 2012 The Chromium Authors. All rights reserved.
|
|
# Use of this source code is governed by a BSD-style license that can be
|
|
# found in the LICENSE file.
|
|
|
|
"""Top-level presubmit script for testing.
|
|
|
|
See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
|
|
for more details on the presubmit API built into depot_tools.
|
|
"""
|
|
|
|
USE_PYTHON3 = True
|
|
|
|
|
|
def CommonChecks(input_api, output_api):
|
|
testing_env = dict(input_api.environ)
|
|
testing_env.update({
|
|
'PYTHONPATH': input_api.PresubmitLocalPath(),
|
|
'PYTHONDONTWRITEBYTECODE': '1',
|
|
})
|
|
|
|
output = []
|
|
output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
'.',
|
|
[r'^.+_unittest\.py$'],
|
|
run_on_python2=False,
|
|
run_on_python3=USE_PYTHON3,
|
|
skip_shebang_check=True))
|
|
output.extend(input_api.canned_checks.RunUnitTestsInDirectory(
|
|
input_api,
|
|
output_api,
|
|
input_api.os_path.join(input_api.PresubmitLocalPath(),
|
|
'unexpected_passes_common'),
|
|
[r'^.+_unittest\.py$'],
|
|
env=testing_env,
|
|
run_on_python2=False,
|
|
run_on_python3=USE_PYTHON3))
|
|
files_to_skip = input_api.DEFAULT_FILES_TO_SKIP
|
|
if input_api.is_windows:
|
|
# These scripts don't run on Windows and should not be linted on Windows -
|
|
# trying to do so will lead to spurious errors.
|
|
files_to_skip += ('xvfb.py', '.*host_info.py')
|
|
output.extend(input_api.canned_checks.RunPylint(
|
|
input_api,
|
|
output_api,
|
|
files_to_skip=files_to_skip,
|
|
version='2.7'))
|
|
|
|
return output
|
|
|
|
|
|
def CheckChangeOnUpload(input_api, output_api):
|
|
return CommonChecks(input_api, output_api)
|
|
|
|
|
|
def CheckChangeOnCommit(input_api, output_api):
|
|
return CommonChecks(input_api, output_api)
|